buffer: refactor to use primordials instead of Array#reduce

aduh95 · danielleadams · commit 9db9be774ba6 · 2020-12-07T13:55:50.000-05:00
PR-URL: #36392 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -24,6 +24,7 @@
 const {
 Array,
 ArrayIsArray,
+ ArrayPrototypeForEach,
 Error,
 MathFloor,
 MathMin,
@@ -825,11 +826,12 @@ Buffer.prototype[customInspectSymbol] = function inspect(recurseTimes, ctx) {
 if (ctx) {
 let extras = false;
 const filter = ctx.showHidden ? ALL_PROPERTIES : ONLY_ENUMERABLE;
- const obj = getOwnNonIndexProperties(this, filter).reduce((obj, key) => {
- extras = true;
- obj[key] = this[key];
- return obj;
- }, ObjectCreate(null));
+ const obj = ObjectCreate(null);
+ ArrayPrototypeForEach(getOwnNonIndexProperties(this, filter),
+ (key) => {
+ extras = true;
+ obj[key] = this[key];
+ });
 if (extras) {
 if (this.length !== 0)
 str += ', ';

-Original file line number
+Diff line change
 const{
  Array,
  ArrayIsArray,
 + ArrayPrototypeForEach,
  Error,
  MathFloor,
  MathMin,
 if(ctx){
 letextras=false;
 constfilter=ctx.showHidden ? ALL_PROPERTIES : ONLY_ENUMERABLE;
 -constobj=getOwnNonIndexProperties(this,filter).reduce((obj,key)=>{
 -extras=true;
 -obj[key]=this[key];
 -returnobj;
 -},ObjectCreate(null));
 +constobj=ObjectCreate(null);
 +ArrayPrototypeForEach(getOwnNonIndexProperties(this,filter),
 +(key)=>{
 +extras=true;
 +obj[key]=this[key];
 +});
 if(extras){
 if(this.length!==0)
 str+=', ';