assert: fix deepStrictEqual on errors when cause is not undefined

PR-URL: #55406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: geeksilva97

lib/internal/assert/assertion_error.js

@@ -15,6 +15,8 @@ const {
  StringPrototypeSplit,
 }=primordials;
 
+const{ isError }=require('internal/util');
+
 const{ inspect }=require('internal/util/inspect');
 constcolors=require('internal/util/colors');
 const{ validateObject }=require('internal/validators');
@@ -47,6 +49,15 @@ function copyError(source) {
 __proto__: null,
 value: source.message,
 });
+if(source.cause!==undefined){
+letcause=source.cause;
+
+if(isError(cause)){
+cause=copyError(cause);
+}
+
+ObjectDefineProperty(target,'cause',{__proto__: null,value: cause});
+}
 returntarget;
 }
 

test/parallel/test-assert-deep-with-error.js

@@ -0,0 +1,39 @@
+'use strict';
+require('../common');
+constassert=require('assert');
+const{ test }=require('node:test');
+
+constdefaultStartMessage='Expected values to be strictly deep-equal:\n'+
+'+ actual - expected\n'+
+'\n';
+
+test('Handle error causes',()=>{
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a',{cause: newError('x')}),newError('a',{cause: newError('y')}));
+},{message: defaultStartMessage+' [Error: a] {\n'+
+'+ [cause]: [Error: x]\n'+
+'- [cause]: [Error: y]\n'+
+' }\n'});
+
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a'),newError('a',{cause: newError('y')}));
+},{message: defaultStartMessage+'+ [Error: a]\n'+
+'- [Error: a] {\n'+
+'- [cause]: [Error: y]\n'+
+'- }\n'});
+
+assert.throws(()=>{
+assert.deepStrictEqual(newError('a'),newError('a',{cause: {prop: 'value'}}));
+},{message: defaultStartMessage+'+ [Error: a]\n'+
+'- [Error: a] {\n'+
+'- [cause]: {\n'+
+'- prop: \'value\'\n'+
+'- }\n'+
+'- }\n'});
+
+assert.notDeepStrictEqual(newError('a',{cause: newError('x')}),newError('a',{cause: newError('y')}));
+assert.notDeepStrictEqual(
+newError('a',{cause: {prop: 'value'}}),
+newError('a',{cause: {prop: 'a different value'}})
+);
+});