assert,util: correct comparison when both contain same reference

lemire · chharvey · targos · commit 9f3200239782 · 2024-06-20T14:45:16.000+02:00
Co-authored-by: Chris Harvey <1362083+chharvey@users.noreply.github.com> PR-URL: #53431 Refs: #53423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -502,8 +502,9 @@ function setEquiv(a, b, strict, memo) {
 for (const val of b) {
 // Primitive values have already been handled above.
 if (typeof val === 'object' && val !== null) {
- if (!setHasEqualElement(set, val, strict, memo))
+ if (!a.has(val) && !setHasEqualElement(set, val, strict, memo)) {
 return false;
+ }
 } else if (!strict &&
 !a.has(val) &&
 !setHasEqualElement(set, val, strict, memo)) {
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -375,7 +375,11 @@ assertOnlyDeepEqual(
 new Map([[undefined, null], ['+000', 2n]]),
 new Map([[null, undefined], [false, '2']]),
 );
-
+const xarray = ['x'];
+assertDeepAndStrictEqual(
+ new Set([xarray, ['y']]),
+ new Set([xarray, ['y']])
+);
 assertOnlyDeepEqual(
 new Set([null, '', 1n, 5, 2n, false]),
 new Set([undefined, 0, 5n, true, '2', '-000'])

-Original file line number
+Diff line change
 for(constvalofb){
 // Primitive values have already been handled above.
 if(typeofval==='object'&&val!==null){
 -if(!setHasEqualElement(set,val,strict,memo))
 +if(!a.has(val)&&!setHasEqualElement(set,val,strict,memo)){
 returnfalse;
 +}
 }elseif(!strict&&
 !a.has(val)&&
 !setHasEqualElement(set,val,strict,memo)){
-Original file line number
+Diff line change
 newMap([[undefined,null],['+000',2n]]),
 newMap([[null,undefined],[false,'2']]),
 );
+-
 +constxarray=['x'];
 +assertDeepAndStrictEqual(
 +newSet([xarray,['y']]),
 +newSet([xarray,['y']])
 +);
 assertOnlyDeepEqual(
 newSet([null,'',1n,5,2n,false]),
 newSet([undefined,0,5n,true,'2','-000'])