Skip to content

Commit 9fed62f

Browse files
Trotttargos
authored andcommitted
test: remove common.skipIfInspectorEnabled()
common.skipIfInspectorEnabled() is only used once in all of the tests. The test is more clear (in my opinion, at least) without the abstraction so put the check directly in the test. Additionally, it honestly looks like an error (which is how I noticed it in the first place) and that someone mistyped the far more common skipIfInspectorDisabled(). PR-URL: #29993 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent d9b5508 commit 9fed62f

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎test/common/index.js‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -651,12 +651,6 @@ function skipIfInspectorDisabled() {
651651
}
652652
}
653653

654-
functionskipIfInspectorEnabled(){
655-
if(process.features.inspector){
656-
skip('V8 inspector is enabled');
657-
}
658-
}
659-
660654
functionskipIfReportDisabled(){
661655
if(!process.config.variables.node_report){
662656
skip('Diagnostic reporting is disabled');
@@ -789,7 +783,6 @@ module.exports = {
789783
skipIf32Bits,
790784
skipIfEslintMissing,
791785
skipIfInspectorDisabled,
792-
skipIfInspectorEnabled,
793786
skipIfReportDisabled,
794787
skipIfWorker,
795788

‎test/parallel/test-coverage-with-inspector-disabled.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22

33
constcommon=require('../common');
4-
common.skipIfInspectorEnabled();
4+
if(process.features.inspector){
5+
common.skip('V8 inspector is enabled');
6+
}
57

68
constfixtures=require('../common/fixtures');
79
constassert=require('assert');

0 commit comments

Comments
 (0)