tty: initialize winSize array with values

targos · targos · commit a033dff2f2ae · 2024-10-02T07:57:32.000+02:00
Assigning to a holey array in the native layer may crash if it has getters that throw. Refs: #54186 PR-URL: #54281 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/lib/tty.js b/lib/tty.js
@@ -22,7 +22,6 @@
 'use strict';
 
 const {
- Array,
 NumberIsInteger,
 ObjectSetPrototypeOf,
 } = primordials;
@@ -106,7 +105,7 @@ function WriteStream(fd) {
 // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
 this._handle.setBlocking(true);
 
- const winSize = new Array(2);
+ const winSize = [0, 0];
 const err = this._handle.getWindowSize(winSize);
 if (!err) {
 this.columns = winSize[0];
@@ -126,7 +125,7 @@ WriteStream.prototype.hasColors = hasColors;
 WriteStream.prototype._refreshSize = function() {
 const oldCols = this.columns;
 const oldRows = this.rows;
- const winSize = new Array(2);
+ const winSize = [0, 0];
 const err = this._handle.getWindowSize(winSize);
 if (err) {
 this.emit('error', new errors.ErrnoException(err, 'getWindowSize'));

-Original file line number
+Diff line change
 'use strict';
 const{
 - Array,
  NumberIsInteger,
  ObjectSetPrototypeOf,
 }=primordials;
 // Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
 this._handle.setBlocking(true);
 -constwinSize=newArray(2);
 +constwinSize=[0,0];
 consterr=this._handle.getWindowSize(winSize);
 if(!err){
 this.columns=winSize[0];
 WriteStream.prototype._refreshSize=function(){
 constoldCols=this.columns;
 constoldRows=this.rows;
 -constwinSize=newArray(2);
 +constwinSize=[0,0];
 consterr=this._handle.getWindowSize(winSize);
 if(err){
 this.emit('error',newerrors.ErrnoException(err,'getWindowSize'));