build: make configure --without-snapshot a no-op

From V8 7.9, the option will no longer exist upstream.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1796325
PR-URL: #30021
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: targos

configure.py

@@ -507,7 +507,7 @@
 
 parser.add_option('--without-snapshot',
 action='store_true',
-dest='without_snapshot',
+dest='unused_without_snapshot',
 help=optparse.SUPPRESS_HELP)
 
 parser.add_option('--without-siphash',
@@ -967,13 +967,13 @@ def configure_node(o):
 cross_compiling= (options.cross_compiling
 ifoptions.cross_compilingisnotNone
 elsetarget_arch!=host_arch)
-want_snapshots=notoptions.without_snapshot
-o['variables']['want_separate_host_toolset'] =int(
-cross_compilingandwant_snapshots)
+ifoptions.unused_without_snapshot:
+warn('building --without-snapshot is no longer possible')
+
+o['variables']['want_separate_host_toolset'] =int(cross_compiling)
 
 ifnotoptions.without_node_snapshot:
-o['variables']['node_use_node_snapshot'] =b(
-notcross_compilingandwant_snapshots)
+o['variables']['node_use_node_snapshot'] =b(notcross_compiling)
 else:
 o['variables']['node_use_node_snapshot'] ='false'
 
@@ -1177,7 +1177,6 @@ def configure_v8(o):
 o['variables']['v8_random_seed'] =0# Use a random seed for hash tables.
 o['variables']['v8_promise_internal_field_count'] =1# Add internal field to promises for async hooks.
 o['variables']['v8_use_siphash'] =0ifoptions.without_siphashelse1
-o['variables']['v8_use_snapshot'] =0ifoptions.without_snapshotelse1
 o['variables']['v8_trace_maps'] =1ifoptions.trace_mapselse0
 o['variables']['node_use_v8_platform'] =b(notoptions.without_v8_platform)
 o['variables']['node_use_bundled_v8'] =b(notoptions.without_bundled_v8)

node.gyp

@@ -1,7 +1,7 @@
 {
 'variables': {
 'v8_use_siphash%': 0,
-'v8_use_snapshot%': 0,
+'v8_use_snapshot%': 1,
 'v8_trace_maps%': 0,
 'node_use_dtrace%': 'false',
 'node_use_etw%': 'false',