test: use destructuring for accessing setting values

yedlosh · UlisesGascon · commit a376284d8a6b · 2023-12-11T17:50:32.000Z
PR-URL: #50609 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-http2-session-settings.js b/test/parallel/test-http2-session-settings.js
@@ -104,15 +104,15 @@ server.listen(
 ['maxHeaderListSize', 2 ** 32],
 ['maxHeaderSize', -1],
 ['maxHeaderSize', 2 ** 32],
- ].forEach((i) => {
+ ].forEach(([key, value]) => {
 const settings = {};
- settings[i[0]] = i[1];
+ settings[key] = value;
 assert.throws(
 () => client.settings(settings),
 {
 name: 'RangeError',
 code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
- message: `Invalid value for setting "${i[0]}": ${i[1]}`
+ message: `Invalid value for setting "${key}": ${value}`
 }
 );
 });

-Original file line number
+Diff line change
 ['maxHeaderListSize',2**32],
 ['maxHeaderSize',-1],
 ['maxHeaderSize',2**32],
 -].forEach((i)=>{
 +].forEach(([key,value])=>{
 constsettings={};
 -settings[i[0]]=i[1];
 +settings[key]=value;
 assert.throws(
 ()=>client.settings(settings),
+{
 name: 'RangeError',
 code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
 -message: `Invalid value for setting "${i[0]}": ${i[1]}`
 +message: `Invalid value for setting "${key}": ${value}`
+}
 );
 });