crypto: make update(buf, enc) ignore encoding

Make the cipher/decipher/hash/hmac update() methods ignore the input
encoding when the input is a buffer.
This is the documented behavior but some inputs were rejected, notably
when the specified encoding is 'hex' and the buffer has an odd length
(because a _string_ with an odd length is never a valid hex string.)
The sign/verify update() methods work okay because they use different
validation logic.
Fixes: #31751
PR-URL: #31766
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Author: bnoordhuis

lib/internal/crypto/cipher.js

@@ -151,13 +151,13 @@ Cipher.prototype.update = function update(data, inputEncoding, outputEncoding) {
 inputEncoding=inputEncoding||encoding;
 outputEncoding=outputEncoding||encoding;
 
-if(typeofdata!=='string'&&!isArrayBufferView(data)){
+if(typeofdata==='string'){
+validateEncoding(data,inputEncoding);
+}elseif(!isArrayBufferView(data)){
 thrownewERR_INVALID_ARG_TYPE(
 'data',['string','Buffer','TypedArray','DataView'],data);
 }
 
-validateEncoding(data,inputEncoding);
-
 constret=this[kHandle].update(data,inputEncoding);
 
 if(outputEncoding&&outputEncoding!=='buffer'){

lib/internal/crypto/hash.js

@@ -78,17 +78,13 @@ Hash.prototype.update = function update(data, encoding) {
 if(state[kFinalized])
 thrownewERR_CRYPTO_HASH_FINALIZED();
 
-if(typeofdata!=='string'&&!isArrayBufferView(data)){
-thrownewERR_INVALID_ARG_TYPE('data',
-['string',
-'Buffer',
-'TypedArray',
-'DataView'],
-data);
+if(typeofdata==='string'){
+validateEncoding(data,encoding);
+}elseif(!isArrayBufferView(data)){
+thrownewERR_INVALID_ARG_TYPE(
+'data',['string','Buffer','TypedArray','DataView'],data);
 }
 
-validateEncoding(data,encoding);
-
 if(!this[kHandle].update(data,encoding))
 thrownewERR_CRYPTO_HASH_UPDATE_FAILED();
 returnthis;

test/parallel/test-crypto-update-encoding.js

@@ -0,0 +1,22 @@
+'use strict';
+constcommon=require('../common');
+
+if(!common.hasCrypto)
+common.skip('missing crypto');
+
+constcrypto=require('crypto');
+
+constzeros=Buffer.alloc;
+constkey=zeros(16);
+constiv=zeros(16);
+
+constcipher=()=>crypto.createCipheriv('aes-128-cbc',key,iv);
+constdecipher=()=>crypto.createDecipheriv('aes-128-cbc',key,iv);
+consthash=()=>crypto.createSign('sha256');
+consthmac=()=>crypto.createHmac('sha256',key);
+constsign=()=>crypto.createSign('sha256');
+constverify=()=>crypto.createVerify('sha256');
+
+for(constfof[cipher,decipher,hash,hmac,sign,verify])
+for(constnof[15,16])
+f().update(zeros(n),'hex');// Should ignore inputEncoding.