test: use platform-based timeout for reliability

Trott · Myles Borins · commit a77dcfec0645 · 2016-01-19T11:52:15.000-08:00
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time to time. Use a platform-based timeout to improve reliability. PR-URL: #4015 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io>
diff --git a/test/parallel/test-http-client-timeout-with-data.js b/test/parallel/test-http-client-timeout-with-data.js
@@ -1,7 +1,7 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var http = require('http');
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
 
 var ntimeouts = 0;
 var nchunks = 0;
@@ -11,21 +11,21 @@ process.on('exit', function() {
 assert.equal(nchunks, 2);
 });
 
-var options = {
+const options = {
 method: 'GET',
 port: common.PORT,
 host: '127.0.0.1',
 path: '/'
 };
 
-var server = http.createServer(function(req, res) {
+const server = http.createServer(function(req, res) {
 res.writeHead(200, {'Content-Length':'2'});
 res.write('*');
- setTimeout(function() { res.end('*'); }, 100);
+ setTimeout(function() { res.end('*'); }, common.platformTimeout(100));
 });
 
 server.listen(options.port, options.host, function() {
- var req = http.request(options, onresponse);
+ const req = http.request(options, onresponse);
 req.end();
 
 function onresponse(res) {

-Original file line number
+Diff line change
@@ @@ -1,7 +1,7 @@ @@
 'use strict';
 -varcommon=require('../common');
 -varassert=require('assert');
 -varhttp=require('http');
 +constcommon=require('../common');
 +constassert=require('assert');
 +consthttp=require('http');
 varntimeouts=0;
 varnchunks=0;
 assert.equal(nchunks,2);
 });
 -varoptions={
 +constoptions={
 method: 'GET',
 port: common.PORT,
 host: '127.0.0.1',
 path: '/'
 };
 -varserver=http.createServer(function(req,res){
 +constserver=http.createServer(function(req,res){
 res.writeHead(200,{'Content-Length':'2'});
 res.write('*');
 -setTimeout(function(){res.end('*');},100);
 +setTimeout(function(){res.end('*');},common.platformTimeout(100));
 });
 server.listen(options.port,options.host,function(){
 -varreq=http.request(options,onresponse);
 +constreq=http.request(options,onresponse);
 req.end();
 functiononresponse(res){