src: protect global state with mutexes

Protect environment variables and inherently per-process state with
mutexes, to better accommodate Node’s usage in
multi-threading environments.
Thanks to Stephen Belanger for reviewing this change in its original PR.
Refs: ayojs/ayo#82
PR-URL: #20542
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Author: addaleax

src/node.cc

@@ -171,6 +171,9 @@ using v8::Value;
 
 using AsyncHooks = Environment::AsyncHooks;
 
+static Mutex process_mutex;
+static Mutex environ_mutex;
+
 staticbool print_eval = false;
 staticbool force_repl = false;
 staticbool syntax_check_only = false;
@@ -698,9 +701,12 @@ bool SafeGetenv(const char* key, std::string* text) {
 goto fail;
 #endif
 
-if (constchar* value = getenv(key)) {
- *text = value;
-returntrue;
+ {
+ Mutex::ScopedLock lock(environ_mutex);
+if (constchar* value = getenv(key)) {
+ *text = value;
+returntrue;
+ }
  }
 
 fail:
@@ -1358,6 +1364,7 @@ void AppendExceptionLine(Environment* env,
 if (!can_set_arrow || (mode == FATAL_ERROR && !err_obj->IsNativeError())) {
 if (env->printed_error())
 return;
+ Mutex::ScopedLock lock(process_mutex);
  env->set_printed_error(true);
 
 uv_tty_reset_mode();
@@ -2624,7 +2631,6 @@ static void ProcessTitleSetter(Local<Name> property,
  Local<Value> value,
 const PropertyCallbackInfo<void>& info) {
  node::Utf8Value title(info.GetIsolate(), value);
-// TODO(piscisaureus): protect with a lock
 uv_set_process_title(*title);
 }
 
@@ -2635,6 +2641,7 @@ static void EnvGetter(Local<Name> property,
 if (property->IsSymbol()) {
 return info.GetReturnValue().SetUndefined();
  }
+ Mutex::ScopedLock lock(environ_mutex);
 #ifdef __POSIX__
  node::Utf8Value key(isolate, property);
 constchar* val = getenv(*key);
@@ -2675,6 +2682,8 @@ static void EnvSetter(Local<Name> property,
 "DEP0104").IsNothing())
 return;
  }
+
+ Mutex::ScopedLock lock(environ_mutex);
 #ifdef __POSIX__
  node::Utf8Value key(info.GetIsolate(), property);
  node::Utf8Value val(info.GetIsolate(), value);
@@ -2695,6 +2704,7 @@ static void EnvSetter(Local<Name> property,
 
 staticvoidEnvQuery(Local<Name> property,
 const PropertyCallbackInfo<Integer>& info) {
+ Mutex::ScopedLock lock(environ_mutex);
 int32_t rc = -1; // Not found unless proven otherwise.
 if (property->IsString()) {
 #ifdef __POSIX__
@@ -2724,6 +2734,7 @@ static void EnvQuery(Local<Name> property,
 
 staticvoidEnvDeleter(Local<Name> property,
 const PropertyCallbackInfo<Boolean>& info) {
+ Mutex::ScopedLock lock(environ_mutex);
 if (property->IsString()) {
 #ifdef __POSIX__
  node::Utf8Value key(info.GetIsolate(), property);
@@ -2749,6 +2760,7 @@ static void EnvEnumerator(const PropertyCallbackInfo<Array>& info) {
  Local<Value> argv[NODE_PUSH_VAL_TO_ARRAY_MAX];
 size_t idx = 0;
 
+ Mutex::ScopedLock lock(environ_mutex);
 #ifdef __POSIX__
 int size = 0;
 while (environ[size])
@@ -2864,6 +2876,7 @@ static Local<Object> GetFeatures(Environment* env) {
 
 staticvoidDebugPortGetter(Local<Name> property,
 const PropertyCallbackInfo<Value>& info) {
+ Mutex::ScopedLock lock(process_mutex);
 int port = debug_options.port();
 #if HAVE_INSPECTOR
 if (port == 0) {
@@ -2879,6 +2892,7 @@ static void DebugPortGetter(Local<Name> property,
 staticvoidDebugPortSetter(Local<Name> property,
  Local<Value> value,
 const PropertyCallbackInfo<void>& info) {
+ Mutex::ScopedLock lock(process_mutex);
  debug_options.set_port(value->Int32Value());
 }
 

src/node_crypto.cc

@@ -715,6 +715,9 @@ void SecureContext::SetCert(const FunctionCallbackInfo<Value>& args) {
 
 staticX509_STORE* NewRootCertStore() {
 static std::vector<X509*> root_certs_vector;
+static Mutex root_certs_vector_mutex;
+ Mutex::ScopedLock lock(root_certs_vector_mutex);
+
 if (root_certs_vector.empty()) {
 for (size_t i = 0; i < arraysize(root_certs); i++) {
 BIO* bp = NodeBIO::NewFixed(root_certs[i], strlen(root_certs[i]));

src/node_internals.h

@@ -25,6 +25,7 @@
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
 #include"node.h"
+#include"node_mutex.h"
 #include"node_persistent.h"
 #include"util-inl.h"
 #include"env-inl.h"