lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses

jasnell · targos · commit aa817853cda2 · 2025-02-25T17:51:07.000+01:00
PR-URL: #57177 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/fs/recursive_watch.js b/lib/internal/fs/recursive_watch.js
@@ -68,7 +68,7 @@ class FSWatcher extends EventEmitter {
 if (encoding != null) {
 // This is required since on macOS and Windows it throws ERR_INVALID_ARG_VALUE
 if (typeof encoding !== 'string') {
- throw new ERR_INVALID_ARG_VALUE(encoding, 'options.encoding');
+ throw new ERR_INVALID_ARG_VALUE('options.encoding', encoding);
 }
 }
 
diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js
@@ -318,7 +318,7 @@ async function* watch(filename, options = kEmptyObject) {
 
 if (encoding && !isEncoding(encoding)) {
 const reason = 'is invalid encoding';
- throw new ERR_INVALID_ARG_VALUE(encoding, 'encoding', reason);
+ throw new ERR_INVALID_ARG_VALUE('encoding', encoding, reason);
 }
 
 if (signal?.aborted)
diff --git a/lib/internal/quic/quic.js b/lib/internal/quic/quic.js
@@ -2069,7 +2069,7 @@ function processSessionOptions(options, forServer = false) {
 if (cc !== undefined) {
 validateString(cc, 'options.cc');
 if (cc !== 'reno' || cc !== 'bbr' || cc !== 'cubic') {
- throw new ERR_INVALID_ARG_VALUE(cc, 'options.cc');
+ throw new ERR_INVALID_ARG_VALUE('options.cc', cc);
 }
 }
 
diff --git a/lib/internal/webstreams/adapters.js b/lib/internal/webstreams/adapters.js
@@ -529,7 +529,7 @@ function newStreamReadableFromReadableStream(readableStream, options = kEmptyObj
 } = options;
 
 if (encoding !== undefined && !Buffer.isEncoding(encoding))
- throw new ERR_INVALID_ARG_VALUE(encoding, 'options.encoding');
+ throw new ERR_INVALID_ARG_VALUE('options.encoding', encoding);
 validateBoolean(objectMode, 'options.objectMode');
 
 const reader = readableStream.getReader();
@@ -686,7 +686,7 @@ function newStreamDuplexFromReadableWritablePair(pair = kEmptyObject, options =
 
 validateBoolean(objectMode, 'options.objectMode');
 if (encoding !== undefined && !Buffer.isEncoding(encoding))
- throw new ERR_INVALID_ARG_VALUE(encoding, 'options.encoding');
+ throw new ERR_INVALID_ARG_VALUE('options.encoding', encoding);
 
 const writer = writableStream.getWriter();
 const reader = readableStream.getReader();

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class FSWatcher extends EventEmitter {`
`68`	`68`	`if(encoding!=null){`
`69`	`69`	`// This is required since on macOS and Windows it throws ERR_INVALID_ARG_VALUE`
`70`	`70`	`if(typeofencoding!=='string'){`
`71`		`-thrownewERR_INVALID_ARG_VALUE(encoding,'options.encoding');`
	`71`	`+thrownewERR_INVALID_ARG_VALUE('options.encoding',encoding);`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`
Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ async function* watch(filename, options = kEmptyObject) {`
`318`	`318`
`319`	`319`	`if(encoding&&!isEncoding(encoding)){`
`320`	`320`	`constreason='is invalid encoding';`
`321`		`-thrownewERR_INVALID_ARG_VALUE(encoding,'encoding',reason);`
	`321`	`+thrownewERR_INVALID_ARG_VALUE('encoding',encoding,reason);`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`if(signal?.aborted)`
Original file line number	Diff line number	Diff line change
`@@ -2069,7 +2069,7 @@ function processSessionOptions(options, forServer = false) {`
`2069`	`2069`	`if(cc!==undefined){`
`2070`	`2070`	`validateString(cc,'options.cc');`
`2071`	`2071`	`if(cc!=='reno'\|\|cc!=='bbr'\|\|cc!=='cubic'){`
`2072`		`-thrownewERR_INVALID_ARG_VALUE(cc,'options.cc');`
	`2072`	`+thrownewERR_INVALID_ARG_VALUE('options.cc',cc);`
`2073`	`2073`	`}`
`2074`	`2074`	`}`
`2075`	`2075`
-Original file line number
+Diff line change
 }=options;
 if(encoding!==undefined&&!Buffer.isEncoding(encoding))
 -thrownewERR_INVALID_ARG_VALUE(encoding,'options.encoding');
 +thrownewERR_INVALID_ARG_VALUE('options.encoding',encoding);
 validateBoolean(objectMode,'options.objectMode');
 constreader=readableStream.getReader();
 validateBoolean(objectMode,'options.objectMode');
 if(encoding!==undefined&&!Buffer.isEncoding(encoding))
 -thrownewERR_INVALID_ARG_VALUE(encoding,'options.encoding');
 +thrownewERR_INVALID_ARG_VALUE('options.encoding',encoding);
 constwriter=writableStream.getWriter();
 constreader=readableStream.getReader();