test: refactor several parallel/test-timer tests

Change var to const/let. Simplify test-timers-uncaught-exception.
Backport-PR-URL: #12401
PR-URL: #10524
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Author: BethGriggs

test/parallel/test-timers-immediate-queue.js

@@ -6,10 +6,8 @@ const assert = require('assert');
 // but immediates queued while processing the current queue should happen
 // on the next turn of the event loop.
 
-// in v0.10 hit should be 1, because we only process one cb per turn
-// in v0.11 and beyond it should be the exact same size of QUEUE
-// if we're letting things recursively add to the immediate QUEUE hit will be
-// > QUEUE
+// hit should be the exact same size of QUEUE, if we're letting things
+// recursively add to the immediate QUEUE hit will be > QUEUE
 
 letticked=false;
 

test/parallel/test-timers-non-integer-delay.js

@@ -1,4 +1,6 @@
 'use strict';
+require('../common');
+
 /*
  * This test makes sure that non-integer timer delays do not make the process
  * hang. See https://github.com/joyent/node/issues/8065 and
@@ -15,8 +17,6 @@
  * it 100%.
  */
 
-require('../common');
-
 constTIMEOUT_DELAY=1.1;
 constNB_TIMEOUTS_FIRED=50;
 

test/parallel/test-timers-ordering.js

@@ -1,8 +1,8 @@
 'use strict';
 require('../common');
 constassert=require('assert');
-constTimer=process.binding('timer_wrap').Timer;
 
+constTimer=process.binding('timer_wrap').Timer;
 constN=30;
 
 letlast_i=0;

test/parallel/test-timers-uncaught-exception.js

@@ -1,40 +1,19 @@
 'use strict';
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 
-letexceptions=0;
-lettimer1=0;
-lettimer2=0;
+consterrorMsg='BAM!';
 
 // the first timer throws...
-console.error('set first timer');
-setTimeout(function(){
-console.error('first timer');
-timer1++;
-thrownewError('BAM!');
-},100);
+setTimeout(common.mustCall(function(){
+thrownewError(errorMsg);
+}),1);
 
 // ...but the second one should still run
-console.error('set second timer');
-setTimeout(function(){
-console.error('second timer');
-assert.strictEqual(timer1,1);
-timer2++;
-},100);
+setTimeout(common.mustCall(function(){}),1);
 
 functionuncaughtException(err){
-console.error('uncaught handler');
-assert.strictEqual(err.message,'BAM!');
-exceptions++;
+assert.strictEqual(err.message,errorMsg);
 }
-process.on('uncaughtException',uncaughtException);
 
-letexited=false;
-process.on('exit',function(){
-assert(!exited);
-exited=true;
-process.removeListener('uncaughtException',uncaughtException);
-assert.strictEqual(exceptions,1);
-assert.strictEqual(timer1,1);
-assert.strictEqual(timer2,1);
-});
+process.on('uncaughtException',common.mustCall(uncaughtException));