test: remove common.PORT in test tls ticket cluster

ooHmartY · MylesBorins · commit aaf8044a81a8 · 2017-07-11T17:43:47.000+01:00
PR-URL: #12715 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
diff --git a/test/parallel/test-tls-ticket-cluster.js b/test/parallel/test-tls-ticket-cluster.js
@@ -20,10 +20,11 @@ if (cluster.isMaster) {
 let reqCount = 0;
 let lastSession = null;
 let shootOnce = false;
+ let workerPort = null;
 
 function shoot() {
- console.error('[master] connecting');
- const c = tls.connect(common.PORT, {
+ console.error('[master] connecting', workerPort);
+ const c = tls.connect(workerPort, {
 session: lastSession,
 rejectUnauthorized: false
 }, function() {
@@ -42,11 +43,12 @@ if (cluster.isMaster) {
 
 function fork() {
 const worker = cluster.fork();
- worker.on('message', function(msg) {
+ worker.on('message', function({ msg, port }) {
 console.error('[master] got %j', msg);
 if (msg === 'reused') {
 ++reusedCount;
 } else if (msg === 'listening' && !shootOnce) {
+ workerPort = port || workerPort;
 shootOnce = true;
 shoot();
 }
@@ -78,15 +80,19 @@ const options = {
 
 const server = tls.createServer(options, function(c) {
 if (c.isSessionReused()) {
- process.send('reused');
+ process.send({ msg: 'reused' });
 } else {
- process.send('not-reused');
+ process.send({ msg: 'not-reused' });
 }
 c.end();
 });
 
-server.listen(common.PORT, function() {
- process.send('listening');
+server.listen(0, function() {
+ const { port } = server.address();
+ process.send({
+ msg: 'listening',
+ port,
+ });
 });
 
 process.on('message', function listener(msg) {

-Original file line number
+Diff line change
 letreqCount=0;
 letlastSession=null;
 letshootOnce=false;
 +letworkerPort=null;
 functionshoot(){
 -console.error('[master] connecting');
 -constc=tls.connect(common.PORT,{
 +console.error('[master] connecting',workerPort);
 +constc=tls.connect(workerPort,{
 session: lastSession,
 rejectUnauthorized: false
 },function(){
 functionfork(){
 constworker=cluster.fork();
 -worker.on('message',function(msg){
 +worker.on('message',function({msg, port }){
 console.error('[master] got %j',msg);
 if(msg==='reused'){
 ++reusedCount;
 }elseif(msg==='listening'&&!shootOnce){
 +workerPort=port||workerPort;
 shootOnce=true;
 shoot();
+}
 constserver=tls.createServer(options,function(c){
 if(c.isSessionReused()){
 -process.send('reused');
 +process.send({msg: 'reused'});
 }else{
 -process.send('not-reused');
 +process.send({msg: 'not-reused'});
+}
 c.end();
 });
 -server.listen(common.PORT,function(){
 -process.send('listening');
 +server.listen(0,function(){
 +const{ port }=server.address();
 +process.send({
 +msg: 'listening',
 + port,
 +});
 });
 process.on('message',functionlistener(msg){