tools: move ESLint tools to tools/eslint

With ESLint flat config, we don't need a hack with `node_modules`
anymore to load ESLint plugins.
This commit moves the node-core plugin out of `tools/node_modules` and
creates a new `tools/eslint` directory to store ESLint tools.
PR-URL: #53393
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Author: targos

Makefile

@@ -1188,6 +1188,7 @@ $(TARBALL): release-only doc-only
 $(RM) -r $(TARNAME)/doc/images # too big
 $(RM) -r $(TARNAME)/test*.tap
 $(RM) -r $(TARNAME)/tools/cpplint.py
+$(RM) -r $(TARNAME)/tools/eslint
 $(RM) -r $(TARNAME)/tools/eslint-rules
 $(RM) -r $(TARNAME)/tools/license-builder.sh
 $(RM) -r $(TARNAME)/tools/node_modules

benchmark/eslint.config_partial.mjs

@@ -1,4 +1,4 @@
-import{requireEslintTool}from'../tools/eslint.config_utils.mjs';
+import{requireEslintTool}from'../tools/eslint/eslint.config_utils.mjs';
 
 constglobals=requireEslintTool('globals');
 

doc/eslint.config_partial.mjs

@@ -1,4 +1,4 @@
-import{requireEslintTool}from'../tools/eslint.config_utils.mjs';
+import{requireEslintTool}from'../tools/eslint/eslint.config_utils.mjs';
 
 constglobals=requireEslintTool('globals');
 

eslint.config.mjs

@@ -5,13 +5,14 @@ import benchmarkConfig from './benchmark/eslint.config_partial.mjs';
 importdocConfigfrom'./doc/eslint.config_partial.mjs';
 importlibConfigfrom'./lib/eslint.config_partial.mjs';
 importtestConfigfrom'./test/eslint.config_partial.mjs';
-importtoolsConfigfrom'./tools/eslint.config_partial.mjs';
+importtoolsConfigfrom'./tools/eslint/eslint.config_partial.mjs';
 import{
 noRestrictedSyntaxCommonAll,
 noRestrictedSyntaxCommonLib,
 requireEslintTool,
 resolveEslintTool,
-}from'./tools/eslint.config_utils.mjs';
+}from'./tools/eslint/eslint.config_utils.mjs';
+importnodeCorefrom'./tools/eslint/eslint-plugin-node-core.js';
 
 constjs=requireEslintTool('@eslint/js');
 constbabelEslintParser=requireEslintTool('@babel/eslint-parser');
@@ -20,7 +21,6 @@ const jsdoc = requireEslintTool('eslint-plugin-jsdoc');
 constmarkdown=requireEslintTool('eslint-plugin-markdown');
 conststylisticJs=requireEslintTool('@stylistic/eslint-plugin-js');
 
-constnodeCore=requireEslintTool('eslint-plugin-node-core');
 nodeCore.RULES_DIR=fileURLToPath(newURL('./tools/eslint-rules',import.meta.url));
 
 // The Module._resolveFilename() monkeypatching is to make it so that ESLint is able to

lib/eslint.config_partial.mjs

@@ -3,7 +3,7 @@
 import{
 noRestrictedSyntaxCommonAll,
 noRestrictedSyntaxCommonLib,
-}from'../tools/eslint.config_utils.mjs';
+}from'../tools/eslint/eslint.config_utils.mjs';
 
 exportdefault[
 {

test/eslint.config_partial.mjs

@@ -3,7 +3,7 @@
 import{
 noRestrictedSyntaxCommonAll,
 requireEslintTool,
-}from'../tools/eslint.config_utils.mjs';
+}from'../tools/eslint/eslint.config_utils.mjs';
 
 constglobals=requireEslintTool('globals');
 

…modules/eslint-plugin-node-core/index.js tools/eslint/eslint-plugin-node-core.jstools/node_modules/eslint-plugin-node-core/index.js renamed to tools/eslint/eslint-plugin-node-core.js tools/node_modules/eslint-plugin-node-core/index.js renamed to tools/eslint/eslint-plugin-node-core.js

@@ -13,7 +13,7 @@ module.exports = {
 if(!cache){
 cache={};
 constfiles=fs.readdirSync(RULES_DIR)
-.filter(filename=>filename.endsWith('.js'))
+.filter((filename)=>filename.endsWith('.js'));
 for(constfileoffiles){
 constname=file.slice(0,-3);
 cache[name]=require(path.resolve(RULES_DIR,file));

tools/eslint.config_partial.mjs tools/eslint/eslint.config_partial.mjstools/eslint.config_partial.mjs renamed to tools/eslint/eslint.config_partial.mjs

@@ -1,6 +1,6 @@
 import{createRequire}from'node:module';
 
-exportconstrequireEslintTool=createRequire(newURL('./node_modules/eslint/',import.meta.url));
+exportconstrequireEslintTool=createRequire(newURL('../node_modules/eslint/',import.meta.url));
 exportconstresolveEslintTool=(request)=>requireEslintTool.resolve(request);
 
 exportconstnoRestrictedSyntaxCommonAll=[