crypto: throw error on invalid object in diffieHellman()

PR-URL: #37016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: Lxxyx

lib/internal/crypto/diffiehellman.js

@@ -290,8 +290,7 @@ function getFormat(format) {
 constdhEnabledKeyTypes=newSafeSet(['dh','ec','x448','x25519']);
 
 functiondiffieHellman(options){
-if(typeofoptions!=='object')
-thrownewERR_INVALID_ARG_TYPE('options','object',options);
+validateObject(options,'options');
 
 const{ privateKey, publicKey }=options;
 if(!(privateKeyinstanceofKeyObject))

test/parallel/test-crypto-dh-stateless.js

@@ -12,6 +12,20 @@ assert.throws(() => crypto.diffieHellman(), {
 message: 'The "options" argument must be of type object. Received undefined'
 });
 
+assert.throws(()=>crypto.diffieHellman(null),{
+name: 'TypeError',
+code: 'ERR_INVALID_ARG_TYPE',
+message: 'The "options" argument must be of type object. Received null'
+});
+
+assert.throws(()=>crypto.diffieHellman([]),{
+name: 'TypeError',
+code: 'ERR_INVALID_ARG_TYPE',
+message:
+'The "options" argument must be of type object. '+
+'Received an instance of Array',
+});
+
 functiontest({publicKey: alicePublicKey,privateKey: alicePrivateKey},
 {publicKey: bobPublicKey,privateKey: bobPrivateKey},
 expectedValue){