inspector: do not change async call stack depth if the worker is done

Fixes: #28528
PR-URL: #28613
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Eugene Ostroukhov

src/inspector_agent.cc

@@ -483,6 +483,11 @@ class NodeInspectorClient : public V8InspectorClient {
  }
 
 voidmaxAsyncCallStackDepthChanged(int depth) override {
+if (waiting_for_sessions_disconnect_) {
+// V8 isolate is mostly done and is only letting Inspector protocol
+// clients gather data.
+return;
+ }
 if (auto agent = env_->inspector_agent()) {
 if (depth == 0) {
  agent->DisableAsyncHook();

test/parallel/test-inspector-async-hook-after-done.js

@@ -0,0 +1,60 @@
+'use strict';
+
+constcommon=require('../common');
+
+common.skipIfInspectorDisabled();
+
+constassert=require('assert');
+const{ Worker }=require('worker_threads');
+const{ Session }=require('inspector');
+
+constsession=newSession();
+
+letdone=false;
+
+session.connect();
+
+session.on('NodeWorker.attachedToWorker',({params: { sessionId }})=>{
+letid=1;
+functionpostToWorkerInspector(method,params){
+session.post('NodeWorker.sendMessageToWorker',{
+ sessionId,
+message: JSON.stringify({id: id++, method, params })
+},()=>console.log(`Message ${method} received the response`));
+}
+
+// Wait for the notification
+functiononMessageReceived({params: { message }}){
+if(!message||
+JSON.parse(message).method!=='NodeRuntime.waitingForDisconnect'){
+session.once('NodeWorker.receivedMessageFromWorker',onMessageReceived);
+return;
+}
+// Force a call to node::inspector::Agent::ToggleAsyncHook by changing the
+// async call stack depth
+postToWorkerInspector('Debugger.setAsyncCallStackDepth',{maxDepth: 1});
+// This is were the original crash happened
+session.post('NodeWorker.detach',{ sessionId },()=>{
+done=true;
+});
+}
+
+onMessageReceived({params: {message: null}});
+// Enable the debugger, otherwise setAsyncCallStackDepth does nothing
+postToWorkerInspector('Debugger.enable');
+// Start waiting for disconnect notification
+postToWorkerInspector('NodeRuntime.notifyWhenWaitingForDisconnect',
+{enabled: true});
+// start worker
+postToWorkerInspector('Runtime.runIfWaitingForDebugger');
+});
+
+session.post('NodeWorker.enable',{waitForDebuggerOnStart: true},()=>{
+newWorker('console.log("Worker is done")',{eval: true})
+.once('exit',()=>{
+setTimeout(()=>{
+assert.strictEqual(done,true);
+console.log('Test is done');
+},0);
+});
+});