Commit ac920e0

Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #65158 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0

4 files changed

Lines changed: 16 additions & 16 deletions

File tree

‎src/node_diagnostics_channel.cc‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
Realm* realm = env->principal_realm();
183183
BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
}
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
.ToLocalChecked()
209209
->NewInstance(context)
210210
.ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
}
213213

214214
binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
env, wrap, binding, index, std::string(name));
216216
}
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
Isolate* isolate = env->isolate();
223223
HandleScope handle_scope(isolate);
224224
Local<Context> context = env->context();
225-
Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
};
227229
Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
->Call(context, v8::Undefined(isolate), arraysize(argv), argv)

‎src/node_diagnostics_channel.h‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;

‎src/permission/permission.cc‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
channels_.erase(it);
305305
}
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
channels_.emplace(scope,
311309
BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
}
314312
return {};
315313
}

‎test/cctest/test_diagnostics_channel.cc‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
std::string name = "test:cctest:grow:" + std::to_string(i);
289290
last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
}
292293

293294
RunJS(isolate_,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit ac920e0
Browse files
jasnelladuh95
jasnell
authored and
aduh95
committed
src: simplify c++ diagnostics channel API
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent ec8fe27 commit ac920e0
4 files changed
Lines changed: 16 additions & 16 deletions
File tree
‎src/node_diagnostics_channel.cc‎
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,11 @@ void Channel::Unlink() {
178178
 publish_fn_.Reset();
179179
}
180180

181-
Channel*Channel::Get(Environment* env, constchar* name) {
181+
BaseObjectPtr<Channel>Channel::Get(Environment* env, std::string_view name) {
182182
 Realm* realm = env->principal_realm();
183183
 BindingData* binding = realm->GetBindingData<BindingData>();
184184
if (binding == nullptr) {
185-
returnnullptr;
185+
return{};
186186
 }
187187
uint32_t index = binding->GetOrCreateChannelIndex(std::string(name));
188188

@@ -208,22 +208,24 @@ Channel* Channel::Get(Environment* env, const char* name) {
208208
 .ToLocalChecked()
209209
 ->NewInstance(context)
210210
 .ToLocal(&wrap)) {
211-
returnnullptr;
211+
return{};
212212
 }
213213

214214
 binding->channels_[index] = MakeDetachedBaseObject<Channel>(
215215
 env, wrap, binding, index, std::string(name));
216216
 }
217217

218-
Channel* channel = binding->channels_[index].get();
218+
auto& channel = binding->channels_[index];
219219

220220
// Late-bind: link to the JS channel when the callback is available.
221221
if (!binding->link_callback_.IsEmpty() && !channel->IsLinked()) {
222222
 Isolate* isolate = env->isolate();
223223
 HandleScope handle_scope(isolate);
224224
 Local<Context> context = env->context();
225-
 Local<String> js_name = String::NewFromUtf8(isolate, name).ToLocalChecked();
226-
 Local<Value> argv[] = {js_name, Integer::NewFromUnsigned(isolate, index)};
225+
 Local<Value> argv[] = {
226+
ToV8Value(context, name).ToLocalChecked(),
227+
Integer::NewFromUnsigned(isolate, index),
228+
 };
227229
 Local<Value> result;
228230
if (binding->link_callback_.Get(isolate)
229231
 ->Call(context, v8::Undefined(isolate), arraysize(argv), argv)
‎src/node_diagnostics_channel.h‎
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ class Channel : public BaseObject {
7373
uint32_t index,
7474
 std::string name);
7575

76-
// Returns a non-owning pointer. Lifetime is managed by BindingData.
77-
static Channel* Get(Environment* env, constchar* name);
76+
static BaseObjectPtr<Channel> Get(Environment* env, std::string_view name);
7877

7978
inlineboolHasSubscribers() const {
8079
return binding_data_ != nullptr && binding_data_->subscribers_[index_] > 0;
‎src/permission/permission.cc‎
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -304,12 +304,10 @@ BaseObjectPtr<diagnostics_channel::Channel> Permission::GetOrCreateChannel(
304304
 channels_.erase(it);
305305
 }
306306
auto channel_name = GetDiagnosticsChannelName(scope);
307-
 diagnostics_channel::Channel* ch =
308-
diagnostics_channel::Channel::Get(env, channel_name.data());
309-
if (ch != nullptr) {
307+
if (auto ch = diagnostics_channel::Channel::Get(env, channel_name)) {
310308
 channels_.emplace(scope,
311309
 BaseObjectWeakPtr<diagnostics_channel::Channel>(ch));
312-
returnBaseObjectPtr<diagnostics_channel::Channel>(ch);
310+
returnch;
313311
 }
314312
return {};
315313
}
‎test/cctest/test_diagnostics_channel.cc‎
Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include"gtest/gtest.h"
44
#include"node_test_fixture.h"
55

6+
using node::BaseObjectPtr;
67
using node::diagnostics_channel::Channel;
78

89
classDiagnosticsChannelTest : publicEnvironmentTestFixture {};
@@ -279,15 +280,15 @@ TEST_F(DiagnosticsChannelTest, NativeChannelsGrowSubscriberStorage) {
279280
"globalThis.__dc.subscribe('test:cctest:grow:0', "
280281
" globalThis.__firstSubscriber);");
281282

282-
Channel* first = Channel::Get(*env, "test:cctest:grow:0");
283-
ASSERT_NE(first, nullptr);
283+
auto first = Channel::Get(*env, "test:cctest:grow:0");
284+
ASSERT_TRUE(first);
284285
ASSERT_TRUE(first->HasSubscribers());
285286

286-
 Channel* last = nullptr;
287+
BaseObjectPtr<Channel> last;
287288
for (size_t i = 1; i <= 1024; i++) {
288289
 std::string name = "test:cctest:grow:" + std::to_string(i);
289290
 last = Channel::Get(*env, name.c_str());
290-
ASSERT_NE(last, nullptr);
291+
ASSERT_TRUE(last);
291292
 }
292293

293294
RunJS(isolate_,
0 commit comments
Comments
 (0)