test: swap var for let/const throughout

Swap var for let/const throughout the common.js module.
Change a snake case variable to camel case starting on line 168.
PR-URL: #10177
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: homosaur

test/common.js

@@ -38,8 +38,9 @@ exports.rootDir = exports.isWindows ? 'c:\\' : '/';
 exports.buildType=process.config.target_defaults.default_configuration;
 
 functionrimrafSync(p){
+letst;
 try{
-varst=fs.lstatSync(p);
+st=fs.lstatSync(p);
 }catch(e){
 if(e.code==='ENOENT')
 return;
@@ -93,9 +94,9 @@ if (process.env.TEST_THREAD_ID) {
 }
 exports.tmpDir=path.join(testRoot,exports.tmpDirName);
 
-varopensslCli=null;
-varinFreeBSDJail=null;
-varlocalhostIPv4=null;
+letopensslCli=null;
+letinFreeBSDJail=null;
+letlocalhostIPv4=null;
 
 exports.localIPv6Hosts=['localhost'];
 if(exports.isLinux){
@@ -165,8 +166,8 @@ Object.defineProperty(exports, 'opensslCli', {get: function() {
 
 if(exports.isWindows)opensslCli+='.exe';
 
-varopenssl_cmd=child_process.spawnSync(opensslCli,['version']);
-if(openssl_cmd.status!==0||openssl_cmd.error!==undefined){
+constopensslCmd=child_process.spawnSync(opensslCli,['version']);
+if(opensslCmd.status!==0||opensslCmd.error!==undefined){
 // openssl command cannot be executed
 opensslCli=false;
 }
@@ -194,7 +195,7 @@ if (exports.isWindows) {
 exports.PIPE=exports.tmpDir+'/test.sock';
 }
 
-varifaces=os.networkInterfaces();
+constifaces=os.networkInterfaces();
 exports.hasIPv6=Object.keys(ifaces).some(function(name){
 return/lo/.test(name)&&ifaces[name].some(function(info){
 returninfo.family==='IPv6';
@@ -204,7 +205,7 @@ exports.hasIPv6 = Object.keys(ifaces).some(function(name) {
 
 exports.ddCommand=function(filename,kilobytes){
 if(exports.isWindows){
-varp=path.resolve(exports.fixturesDir,'create-file.js');
+constp=path.resolve(exports.fixturesDir,'create-file.js');
 return'"'+process.argv[0]+'" "'+p+'" "'+
 filename+'" '+(kilobytes*1024);
 }else{
@@ -214,7 +215,7 @@ exports.ddCommand = function(filename, kilobytes) {
 
 
 exports.spawnCat=function(options){
-varspawn=require('child_process').spawn;
+constspawn=require('child_process').spawn;
 
 if(exports.isWindows){
 returnspawn('more',[],options);
@@ -225,7 +226,7 @@ exports.spawnCat = function(options) {
 
 
 exports.spawnSyncCat=function(options){
-varspawnSync=require('child_process').spawnSync;
+constspawnSync=require('child_process').spawnSync;
 
 if(exports.isWindows){
 returnspawnSync('more',[],options);
@@ -236,7 +237,7 @@ exports.spawnSyncCat = function(options) {
 
 
 exports.spawnPwd=function(options){
-varspawn=require('child_process').spawn;
+constspawn=require('child_process').spawn;
 
 if(exports.isWindows){
 returnspawn('cmd.exe',['/c','cd'],options);
@@ -277,7 +278,7 @@ exports.platformTimeout = function(ms) {
 returnms;// ARMv8+
 };
 
-varknownGlobals=[
+letknownGlobals=[
 Buffer,
 clearImmediate,
 clearInterval,
@@ -351,9 +352,9 @@ function allowGlobals(...whitelist) {
 exports.allowGlobals=allowGlobals;
 
 functionleakedGlobals(){
-varleaked=[];
+constleaked=[];
 
-for(varvalinglobal)
+for(constvalinglobal)
 if(!knownGlobals.includes(global[val]))
 leaked.push(val);
 
@@ -366,21 +367,21 @@ exports.globalCheck = true;
 
 process.on('exit',function(){
 if(!exports.globalCheck)return;
-varleaked=leakedGlobals();
+constleaked=leakedGlobals();
 if(leaked.length>0){
 console.error('Unknown globals: %s',leaked);
 fail('Unknown global found');
 }
 });
 
 
-varmustCallChecks=[];
+constmustCallChecks=[];
 
 
 functionrunCallChecks(exitCode){
 if(exitCode!==0)return;
 
-varfailed=mustCallChecks.filter(function(context){
+constfailed=mustCallChecks.filter(function(context){
 returncontext.actual!==context.expected;
 });
 
@@ -399,7 +400,7 @@ function runCallChecks(exitCode) {
 exports.mustCall=function(fn,expected){
 if(typeofexpected!=='number')expected=1;
 
-varcontext={
+constcontext={
 expected: expected,
 actual: 0,
 stack: (newError()).stack,
@@ -418,9 +419,9 @@ exports.mustCall = function(fn, expected) {
 };
 
 exports.hasMultiLocalhost=functionhasMultiLocalhost(){
-varTCP=process.binding('tcp_wrap').TCP;
-vart=newTCP();
-varret=t.bind('127.0.0.2',exports.PORT);
+constTCP=process.binding('tcp_wrap').TCP;
+constt=newTCP();
+constret=t.bind('127.0.0.2',exports.PORT);
 t.close();
 returnret===0;
 };
@@ -466,7 +467,7 @@ ArrayStream.prototype.write = function() {};
 exports.nodeProcessAborted=functionnodeProcessAborted(exitCode,signal){
 // Depending on the compiler used, node will exit with either
 // exit code 132 (SIGILL), 133 (SIGTRAP) or 134 (SIGABRT).
-varexpectedExitCodes=[132,133,134];
+letexpectedExitCodes=[132,133,134];
 
 // On platforms using KSH as the default shell (like SmartOS),
 // when a process aborts, KSH exits with an exit code that is
@@ -495,8 +496,8 @@ exports.nodeProcessAborted = function nodeProcessAborted(exitCode, signal) {
 };
 
 exports.busyLoop=functionbusyLoop(time){
-varstartTime=Timer.now();
-varstopTime=startTime+time;
+conststartTime=Timer.now();
+conststopTime=startTime+time;
 while(Timer.now()<stopTime){}
 };