Commit ad7c670

Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the members they need, so createDictionaryConverter() reading the optional validator, defaultValue and required members off them resolves through %Object.prototype%. Copy each descriptor once at construction time with every key present. They keep an ordinary prototype because a null-prototype object literal lands in V8 dictionary mode, and dictionaries with no defaults and no required members now skip steps 4.1.5 and 4.1.6. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #65115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670

1 file changed

Lines changed: 45 additions & 11 deletions

File tree

‎lib/internal/webidl.js‎

Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
NumberIsNaN,
2121
NumberMAX_SAFE_INTEGER,
2222
NumberMIN_SAFE_INTEGER,
23+
ObjectPrototypeHasOwnProperty,
2324
ObjectPrototypeIsPrototypeOf,
2425
SafeArrayIterator,
2526
SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
defaultValue,
735+
required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit ad7c670
Browse files
panvaaduh95
panva
authored and
aduh95
committed
lib: harden webidl dictionary member reads
Member descriptors are plain object literals that spell out only the
members they need, so createDictionaryConverter() reading the optional
validator, defaultValue and required members off them resolves through
%Object.prototype%.
Copy each descriptor once at construction time with every key present.
They keep an ordinary prototype because a null-prototype object literal
lands in V8 dictionary mode, and dictionaries with no defaults and no
required members now skip steps 4.1.5 and 4.1.6.
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #65115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
1 parent 1d9dd25 commit ad7c670
1 file changed
Lines changed: 45 additions & 11 deletions
File tree
‎lib/internal/webidl.js‎
Lines changed: 45 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const {
2020
 NumberIsNaN,
2121
 NumberMAX_SAFE_INTEGER,
2222
 NumberMIN_SAFE_INTEGER,
23+
 ObjectPrototypeHasOwnProperty,
2324
 ObjectPrototypeIsPrototypeOf,
2425
 SafeArrayIterator,
2526
 SafeSet,
@@ -699,16 +700,47 @@ function createDictionaryConverter(
699700
constdictionaries=ArrayIsArray(members[0]) ? members : [members];
700701
constsortedDictionaries=[];
701702

703+
functionownMember(member,key){
704+
returnObjectPrototypeHasOwnProperty(member,key) ? member[key] : undefined;
705+
}
706+
707+
// Dictionaries with no defaults and no required members skip steps
708+
// 4.1.5/4.1.6 entirely, keeping the absent-member path free.
709+
letanyMissingMemberHandling=false;
710+
702711
// Web IDL dictionary conversion steps 3-4 process inherited dictionaries
703712
// from least-derived to most-derived and sort only within each dictionary.
704713
// Callers with inheritance pass one member array per dictionary level.
705714
for(leti=0;i<dictionaries.length;i++){
706-
ArrayPrototypePush(
707-
sortedDictionaries,
708-
ArrayPrototypeToSorted(dictionaries[i],compareMembers),
715+
constsortedMembers=ArrayPrototypeToSorted(
716+
dictionaries[i],
717+
compareMembers,
709718
);
719+
// Definition sites spell out only the members they need, so reading the
720+
// optional ones below would resolve through %Object.prototype%.
721+
// Re-materialize each descriptor once with every key present, copied from
722+
// own properties only. The ordinary prototype is deliberate: nothing
723+
// consults it now, and detaching it measurably slows these reads down.
724+
for(letj=0;j<sortedMembers.length;j++){
725+
constmember=sortedMembers[j];
726+
constdefaultValue=ownMember(member,'defaultValue');
727+
constrequired=ownMember(member,'required');
728+
if(typeofdefaultValue==='function'||required){
729+
anyMissingMemberHandling=true;
730+
}
731+
sortedMembers[j]={
732+
key: ownMember(member,'key'),
733+
converter: ownMember(member,'converter'),
734+
 defaultValue,
735+
 required,
736+
validator: ownMember(member,'validator'),
737+
};
738+
}
739+
ArrayPrototypePush(sortedDictionaries,sortedMembers);
710740
}
711741

742+
consthasMissingMemberHandling=anyMissingMemberHandling;
743+
712744
returnfunction(jsDict,options=kEmptyObject){
713745
// Step 1: reject non-object, non-null, non-undefined values.
714746
if(jsDict!=null&&type(jsDict)!=='Object'){
@@ -747,14 +779,16 @@ function createDictionaryConverter(
747779
member.validator?.(idlMemberValue,jsDict);
748780
// Step 4.1.4.2: set idlDict[key] to the IDL value.
749781
idlDict[key]=idlMemberValue;
750-
}elseif(typeofmember.defaultValue==='function'){
751-
// Step 4.1.5: store the member default value.
752-
idlDict[key]=member.defaultValue();
753-
}elseif(member.required){
754-
// Step 4.1.6: required missing members throw.
755-
throwmakeException(
756-
missingDictionaryMemberMessage(dictionaryName,key),
757-
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
782+
}elseif(hasMissingMemberHandling){
783+
if(typeofmember.defaultValue==='function'){
784+
// Step 4.1.5: store the member default value.
785+
idlDict[key]=member.defaultValue();
786+
}elseif(member.required){
787+
// Step 4.1.6: required missing members throw.
788+
throwmakeException(
789+
missingDictionaryMemberMessage(dictionaryName,key),
790+
makeOptions(options,options.context,'ERR_MISSING_OPTION'));
791+
}
758792
}
759793
}
760794
}
0 commit comments
Comments
 (0)