lib: replace string concatenation with template

narkedi · evanlucas · commit afbdd017c165 · 2017-11-13T08:00:12.000-06:00
PR-URL: #16933 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -115,7 +115,7 @@ function rethrow() {
 var backtrace = new Error();
 return function(err) {
 if (err) {
- backtrace.stack = err.name + ': ' + err.message +
+ backtrace.stack = `${err.name}: ${err.message}` +
 backtrace.stack.substr(backtrace.name.length);
 throw backtrace;
 }
@@ -1894,7 +1894,7 @@ fs.mkdtemp = function(prefix, options, callback) {
 var req = new FSReqWrap();
 req.oncomplete = callback;
 
- binding.mkdtemp(prefix + 'XXXXXX', options.encoding, req);
+ binding.mkdtemp(`${prefix}XXXXXX`, options.encoding, req);
 };
 
 
@@ -1907,7 +1907,7 @@ fs.mkdtempSync = function(prefix, options) {
 }
 options = getOptions(options, {});
 nullCheck(prefix);
- return binding.mkdtemp(prefix + 'XXXXXX', options.encoding);
+ return binding.mkdtemp(`${prefix}XXXXXX`, options.encoding);
 };
 
 

-Original file line number
+Diff line change
 varbacktrace=newError();
 returnfunction(err){
 if(err){
 -backtrace.stack=err.name+': '+err.message+
 +backtrace.stack=`${err.name}: ${err.message}`+
 backtrace.stack.substr(backtrace.name.length);
 throwbacktrace;
+}
 varreq=newFSReqWrap();
 req.oncomplete=callback;
 -binding.mkdtemp(prefix+'XXXXXX',options.encoding,req);
 +binding.mkdtemp(`${prefix}XXXXXX`,options.encoding,req);
 };
+}
 options=getOptions(options,{});
 nullCheck(prefix);
 -returnbinding.mkdtemp(prefix+'XXXXXX',options.encoding);
 +returnbinding.mkdtemp(`${prefix}XXXXXX`,options.encoding);
 };