test: simplify test-cli-node-options-docs

PR-URL: #61006
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>

Author: aduh95

test/parallel/test-cli-node-options-docs.js

@@ -39,34 +39,10 @@ for (const [, envVar] of manPageText.matchAll(/\.It Fl (-[a-zA-Z0-9._-]+)/g)) {
 }
 
 for(const[,envVar,config]ofnodeOptionsCC.matchAll(addOptionRE)){
-lethasTrueAsDefaultValue=false;
-letisInNodeOption=false;
-letisV8Option=false;
-letisNoOp=false;
-
-if(config.includes('NoOp{}')){
-isNoOp=true;
-}
-
-if(config.includes('kAllowedInEnvvar')){
-isInNodeOption=true;
-}
-if(config.includes('kDisallowedInEnvvar')){
-isInNodeOption=false;
-}
-
-if(config.includes('V8Option{}')){
-isV8Option=true;
-}
-
-if(/^\s*true\s*$/.test(config.split(',').pop())){
-hasTrueAsDefaultValue=true;
-}
-
-// Exception for HAVE_AMARO conditional default (defaults to true when Amaro is available)
-if(config.includes('HAVE_AMARO')){
-hasTrueAsDefaultValue=true;
-}
+consthasTrueAsDefaultValue=/,\s*(?:true|HAVE_[A-Z_]+)\s*$/.test(config);
+constisInNodeOption=config.includes('kAllowedInEnvvar')&&!config.includes('kDisallowedInEnvvar');
+constisV8Option=config.includes('V8Option{}');
+constisNoOp=config.includes('NoOp{}');
 
 if(
 envVar.startsWith('[')||
@@ -79,50 +55,50 @@ for (const [, envVar, config] of nodeOptionsCC.matchAll(addOptionRE)) {
 }
 
 // Internal API options are documented in /doc/contributing/internal-api.md
-if(newRegExp(`####.*\`${envVar}[[=\\s\\b\`]`).test(internalApiText)===true){
+if(newRegExp(`####.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(internalApiText)){
 manPagesOptions.delete(envVar.slice(1));
 continue;
 }
 
 // CLI options
 if(!isV8Option&&!hasTrueAsDefaultValue){
-if(newRegExp(`###.*\`${envVar}[[=\\s\\b\`]`).test(cliText)===false){
-assert(false,`Should have option ${envVar} documented`);
+if(!newRegExp(`###.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(cliText)){
+assert.fail(`Should have option ${envVar} documented`);
 }else{
 manPagesOptions.delete(envVar.slice(1));
 }
 }
 
-if(!hasTrueAsDefaultValue&&newRegExp(`###.*\`--no${envVar.slice(1)}[[=\\s\\b\`]`).test(cliText)===true){
-assert(false,`Should not have option --no${envVar.slice(1)} documented`);
+if(!hasTrueAsDefaultValue&&newRegExp(`###.*\`--no${RegExp.escape(envVar.slice(1))}[[=\\s\\b\`]`).test(cliText)){
+assert.fail(`Should not have option --no${envVar.slice(1)} documented`);
 }
 
 if(!isV8Option&&hasTrueAsDefaultValue){
-if(newRegExp(`###.*\`--no${envVar.slice(1)}[[=\\s\\b\`]`).test(cliText)===false){
-assert(false,`Should have option --no${envVar.slice(1)} documented`);
+if(!newRegExp(`###.*\`--no${RegExp.escape(envVar.slice(1))}[[=\\s\\b\`]`).test(cliText)){
+assert.fail(`Should have option --no${envVar.slice(1)} documented`);
 }else{
 manPagesOptions.delete(`-no${envVar.slice(1)}`);
 }
 }
 
 // NODE_OPTIONS
 if(isInNodeOption&&!hasTrueAsDefaultValue&&
-newRegExp(`\`${envVar}\``).test(nodeOptionsText)===false){
-assert(false,`Should have option ${envVar} in NODE_OPTIONS documented`);
+!newRegExp(`\`${RegExp.escape(envVar)}\``).test(nodeOptionsText)){
+assert.fail(`Should have option ${envVar} in NODE_OPTIONS documented`);
 }
 
-if(isInNodeOption&&hasTrueAsDefaultValue&&newRegExp(`\`--no${envVar.slice(1)}\``).test(cliText)===false){
-assert(false,`Should have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
+if(isInNodeOption&&hasTrueAsDefaultValue&&!newRegExp(`\`--no${RegExp.escape(envVar.slice(1))}\``).test(cliText)){
+assert.fail(`Should have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
 }
 
-if(!hasTrueAsDefaultValue&&newRegExp(`\`--no${envVar.slice(1)}\``).test(cliText)===true){
-assert(false,`Should not have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
+if(!hasTrueAsDefaultValue&&newRegExp(`\`--no${RegExp.escape(envVar.slice(1))}\``).test(cliText)){
+assert.fail(`Should not have option --no${envVar.slice(1)} in NODE_OPTIONS documented`);
 }
 
 // V8 options
 if(isV8Option){
-if(newRegExp(`###.*\`${envVar}[[=\\s\\b\`]`).test(v8OptionsText)===false){
-assert(false,`Should have option ${envVar} in V8 options documented`);
+if(!newRegExp(`###.*\`${RegExp.escape(envVar)}[[=\\s\\b\`]`).test(v8OptionsText)){
+assert.fail(`Should have option ${envVar} in V8 options documented`);
 }else{
 manPagesOptions.delete(envVar.slice(1));
 }