Skip to content

Commit b239591

Browse files
Gabriel SchulhofMylesBorins
authored andcommitted
n-api,test: make methods static
PR-URL: #20243 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent d4b19cf commit b239591

28 files changed

Lines changed: 139 additions & 137 deletions

File tree

‎test/addons-napi/1_hello_world/binding.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include"../common.h"
33
#include<string.h>
44

5-
napi_valueMethod(napi_envenv, napi_callback_infoinfo) {
5+
staticnapi_valueMethod(napi_envenv, napi_callback_infoinfo) {
66
napi_valueworld;
77
constchar*str="world";
88
size_tstr_len=strlen(str);

‎test/addons-napi/2_function_arguments/binding.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include<node_api.h>
22
#include"../common.h"
33

4-
napi_valueAdd(napi_envenv, napi_callback_infoinfo) {
4+
staticnapi_valueAdd(napi_envenv, napi_callback_infoinfo) {
55
size_targc=2;
66
napi_valueargs[2];
77
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -29,7 +29,7 @@ napi_value Add(napi_env env, napi_callback_info info) {
2929
returnsum;
3030
}
3131

32-
napi_valueInit(napi_envenv, napi_valueexports) {
32+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
3333
napi_property_descriptordesc=DECLARE_NAPI_PROPERTY("add", Add);
3434
NAPI_CALL(env, napi_define_properties(env, exports, 1, &desc));
3535
returnexports;

‎test/addons-napi/3_callbacks/binding.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include"../common.h"
33
#include<string.h>
44

5-
napi_valueRunCallback(napi_envenv, napi_callback_infoinfo) {
5+
staticnapi_valueRunCallback(napi_envenv, napi_callback_infoinfo) {
66
size_targc=2;
77
napi_valueargs[2];
88
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -34,7 +34,7 @@ napi_value RunCallback(napi_env env, napi_callback_info info) {
3434
returnNULL;
3535
}
3636

37-
napi_valueRunCallbackWithRecv(napi_envenv, napi_callback_infoinfo) {
37+
staticnapi_valueRunCallbackWithRecv(napi_envenv, napi_callback_infoinfo) {
3838
size_targc=2;
3939
napi_valueargs[2];
4040
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -45,7 +45,7 @@ napi_value RunCallbackWithRecv(napi_env env, napi_callback_info info) {
4545
returnNULL;
4646
}
4747

48-
napi_valueInit(napi_envenv, napi_valueexports) {
48+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
4949
napi_property_descriptordesc[2] = {
5050
DECLARE_NAPI_PROPERTY("RunCallback", RunCallback),
5151
DECLARE_NAPI_PROPERTY("RunCallbackWithRecv", RunCallbackWithRecv),

‎test/addons-napi/4_object_factory/binding.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include<node_api.h>
22
#include"../common.h"
33

4-
napi_valueCreateObject(napi_envenv, napi_callback_infoinfo) {
4+
staticnapi_valueCreateObject(napi_envenv, napi_callback_infoinfo) {
55
size_targc=1;
66
napi_valueargs[1];
77
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -14,7 +14,7 @@ napi_value CreateObject(napi_env env, napi_callback_info info) {
1414
returnobj;
1515
}
1616

17-
napi_valueInit(napi_envenv, napi_valueexports) {
17+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
1818
NAPI_CALL(env,
1919
napi_create_function(env, "exports", -1, CreateObject, NULL, &exports));
2020
returnexports;

‎test/addons-napi/5_function_factory/binding.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
#include<node_api.h>
22
#include"../common.h"
33

4-
napi_valueMyFunction(napi_envenv, napi_callback_infoinfo) {
4+
staticnapi_valueMyFunction(napi_envenv, napi_callback_infoinfo) {
55
napi_valuestr;
66
NAPI_CALL(env, napi_create_string_utf8(env, "hello world", -1, &str));
77
returnstr;
88
}
99

10-
napi_valueCreateFunction(napi_envenv, napi_callback_infoinfo) {
10+
staticnapi_valueCreateFunction(napi_envenv, napi_callback_infoinfo) {
1111
napi_valuefn;
1212
NAPI_CALL(env,
1313
napi_create_function(env, "theFunction", -1, MyFunction, NULL, &fn));
1414
returnfn;
1515
}
1616

17-
napi_valueInit(napi_envenv, napi_valueexports) {
17+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
1818
NAPI_CALL(env,
1919
napi_create_function(env, "exports", -1, CreateFunction, NULL, &exports));
2020
returnexports;

‎test/addons-napi/test_array/test_array.c‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include<string.h>
33
#include"../common.h"
44

5-
napi_valueTestGetElement(napi_envenv, napi_callback_infoinfo) {
5+
staticnapi_valueTestGetElement(napi_envenv, napi_callback_infoinfo) {
66
size_targc=2;
77
napi_valueargs[2];
88
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -45,7 +45,7 @@ napi_value TestGetElement(napi_env env, napi_callback_info info) {
4545
returnret;
4646
}
4747

48-
napi_valueTestHasElement(napi_envenv, napi_callback_infoinfo) {
48+
staticnapi_valueTestHasElement(napi_envenv, napi_callback_infoinfo) {
4949
size_targc=2;
5050
napi_valueargs[2];
5151
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -84,7 +84,7 @@ napi_value TestHasElement(napi_env env, napi_callback_info info) {
8484
returnret;
8585
}
8686

87-
napi_valueTestDeleteElement(napi_envenv, napi_callback_infoinfo) {
87+
staticnapi_valueTestDeleteElement(napi_envenv, napi_callback_infoinfo) {
8888
size_targc=2;
8989
napi_valueargs[2];
9090

@@ -119,7 +119,7 @@ napi_value TestDeleteElement(napi_env env, napi_callback_info info) {
119119
returnret;
120120
}
121121

122-
napi_valueNew(napi_envenv, napi_callback_infoinfo) {
122+
staticnapi_valueNew(napi_envenv, napi_callback_infoinfo) {
123123
size_targc=1;
124124
napi_valueargs[1];
125125
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -147,7 +147,7 @@ napi_value New(napi_env env, napi_callback_info info) {
147147
returnret;
148148
}
149149

150-
napi_valueNewWithLength(napi_envenv, napi_callback_infoinfo) {
150+
staticnapi_valueNewWithLength(napi_envenv, napi_callback_infoinfo) {
151151
size_targc=1;
152152
napi_valueargs[1];
153153
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -169,7 +169,7 @@ napi_value NewWithLength(napi_env env, napi_callback_info info) {
169169
returnret;
170170
}
171171

172-
napi_valueInit(napi_envenv, napi_valueexports) {
172+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
173173
napi_property_descriptordescriptors[] = {
174174
DECLARE_NAPI_PROPERTY("TestGetElement", TestGetElement),
175175
DECLARE_NAPI_PROPERTY("TestHasElement", TestHasElement),

‎test/addons-napi/test_buffer/test_buffer.c‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ static void noopDeleter(napi_env env, void* data, void* finalize_hint) {
2020
deleterCallCount++;
2121
}
2222

23-
napi_valuenewBuffer(napi_envenv, napi_callback_infoinfo) {
23+
staticnapi_valuenewBuffer(napi_envenv, napi_callback_infoinfo) {
2424
napi_valuetheBuffer;
2525
char*theCopy;
2626
constunsigned intkBufferSize=sizeof(theText);
@@ -37,7 +37,7 @@ napi_value newBuffer(napi_env env, napi_callback_info info) {
3737
returntheBuffer;
3838
}
3939

40-
napi_valuenewExternalBuffer(napi_envenv, napi_callback_infoinfo) {
40+
staticnapi_valuenewExternalBuffer(napi_envenv, napi_callback_infoinfo) {
4141
napi_valuetheBuffer;
4242
char*theCopy=strdup(theText);
4343
NAPI_ASSERT(env, theCopy, "Failed to copy static text for newExternalBuffer");
@@ -53,20 +53,20 @@ napi_value newExternalBuffer(napi_env env, napi_callback_info info) {
5353
returntheBuffer;
5454
}
5555

56-
napi_valuegetDeleterCallCount(napi_envenv, napi_callback_infoinfo) {
56+
staticnapi_valuegetDeleterCallCount(napi_envenv, napi_callback_infoinfo) {
5757
napi_valuecallCount;
5858
NAPI_CALL(env, napi_create_int32(env, deleterCallCount, &callCount));
5959
returncallCount;
6060
}
6161

62-
napi_valuecopyBuffer(napi_envenv, napi_callback_infoinfo) {
62+
staticnapi_valuecopyBuffer(napi_envenv, napi_callback_infoinfo) {
6363
napi_valuetheBuffer;
6464
NAPI_CALL(env, napi_create_buffer_copy(
6565
env, sizeof(theText), theText, NULL, &theBuffer));
6666
returntheBuffer;
6767
}
6868

69-
napi_valuebufferHasInstance(napi_envenv, napi_callback_infoinfo) {
69+
staticnapi_valuebufferHasInstance(napi_envenv, napi_callback_infoinfo) {
7070
size_targc=1;
7171
napi_valueargs[1];
7272
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -85,7 +85,7 @@ napi_value bufferHasInstance(napi_env env, napi_callback_info info) {
8585
returnreturnValue;
8686
}
8787

88-
napi_valuebufferInfo(napi_envenv, napi_callback_infoinfo) {
88+
staticnapi_valuebufferInfo(napi_envenv, napi_callback_infoinfo) {
8989
size_targc=1;
9090
napi_valueargs[1];
9191
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -106,7 +106,7 @@ napi_value bufferInfo(napi_env env, napi_callback_info info) {
106106
returnreturnValue;
107107
}
108108

109-
napi_valuestaticBuffer(napi_envenv, napi_callback_infoinfo) {
109+
staticnapi_valuestaticBuffer(napi_envenv, napi_callback_infoinfo) {
110110
napi_valuetheBuffer;
111111
NAPI_CALL(
112112
env,
@@ -119,7 +119,7 @@ napi_value staticBuffer(napi_env env, napi_callback_info info) {
119119
returntheBuffer;
120120
}
121121

122-
napi_valueInit(napi_envenv, napi_valueexports) {
122+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
123123
napi_valuetheValue;
124124

125125
NAPI_CALL(env,

‎test/addons-napi/test_constructor/test_constructor.c‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
staticdoublevalue_=1;
55
staticdoublestatic_value_=10;
66

7-
napi_valueGetValue(napi_envenv, napi_callback_infoinfo) {
7+
staticnapi_valueGetValue(napi_envenv, napi_callback_infoinfo) {
88
size_targc=0;
99
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, NULL, NULL, NULL));
1010

@@ -16,7 +16,7 @@ napi_value GetValue(napi_env env, napi_callback_info info) {
1616
returnnumber;
1717
}
1818

19-
napi_valueSetValue(napi_envenv, napi_callback_infoinfo) {
19+
staticnapi_valueSetValue(napi_envenv, napi_callback_infoinfo) {
2020
size_targc=1;
2121
napi_valueargs[1];
2222
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -28,7 +28,7 @@ napi_value SetValue(napi_env env, napi_callback_info info) {
2828
returnNULL;
2929
}
3030

31-
napi_valueEcho(napi_envenv, napi_callback_infoinfo) {
31+
staticnapi_valueEcho(napi_envenv, napi_callback_infoinfo) {
3232
size_targc=1;
3333
napi_valueargs[1];
3434
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -38,14 +38,14 @@ napi_value Echo(napi_env env, napi_callback_info info) {
3838
returnargs[0];
3939
}
4040

41-
napi_valueNew(napi_envenv, napi_callback_infoinfo) {
41+
staticnapi_valueNew(napi_envenv, napi_callback_infoinfo) {
4242
napi_value_this;
4343
NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &_this, NULL));
4444

4545
return_this;
4646
}
4747

48-
napi_valueGetStaticValue(napi_envenv, napi_callback_infoinfo) {
48+
staticnapi_valueGetStaticValue(napi_envenv, napi_callback_infoinfo) {
4949
size_targc=0;
5050
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, NULL, NULL, NULL));
5151

@@ -58,7 +58,7 @@ napi_value GetStaticValue(napi_env env, napi_callback_info info) {
5858
}
5959

6060

61-
napi_valueInit(napi_envenv, napi_valueexports) {
61+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
6262
napi_valuenumber;
6363
NAPI_CALL(env, napi_create_double(env, value_, &number));
6464

‎test/addons-napi/test_constructor/test_constructor_name.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33

44
napi_refconstructor_;
55

6-
napi_valueNew(napi_envenv, napi_callback_infoinfo) {
6+
staticnapi_valueNew(napi_envenv, napi_callback_infoinfo) {
77
napi_value_this;
88
NAPI_CALL(env, napi_get_cb_info(env, info, NULL, NULL, &_this, NULL));
99

1010
return_this;
1111
}
1212

13-
napi_valueInit(napi_envenv, napi_valueexports) {
13+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
1414
napi_valuecons;
1515
NAPI_CALL(env, napi_define_class(
1616
env, "MyObject_Extra", 8, New, NULL, 0, NULL, &cons));

‎test/addons-napi/test_conversions/test_conversions.c‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#include<node_api.h>
22
#include"../common.h"
33

4-
napi_valueAsBool(napi_envenv, napi_callback_infoinfo) {
4+
staticnapi_valueAsBool(napi_envenv, napi_callback_infoinfo) {
55
size_targc=1;
66
napi_valueargs[1];
77
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -15,7 +15,7 @@ napi_value AsBool(napi_env env, napi_callback_info info) {
1515
returnoutput;
1616
}
1717

18-
napi_valueAsInt32(napi_envenv, napi_callback_infoinfo) {
18+
staticnapi_valueAsInt32(napi_envenv, napi_callback_infoinfo) {
1919
size_targc=1;
2020
napi_valueargs[1];
2121
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -29,7 +29,7 @@ napi_value AsInt32(napi_env env, napi_callback_info info) {
2929
returnoutput;
3030
}
3131

32-
napi_valueAsUInt32(napi_envenv, napi_callback_infoinfo) {
32+
staticnapi_valueAsUInt32(napi_envenv, napi_callback_infoinfo) {
3333
size_targc=1;
3434
napi_valueargs[1];
3535
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -43,7 +43,7 @@ napi_value AsUInt32(napi_env env, napi_callback_info info) {
4343
returnoutput;
4444
}
4545

46-
napi_valueAsInt64(napi_envenv, napi_callback_infoinfo) {
46+
staticnapi_valueAsInt64(napi_envenv, napi_callback_infoinfo) {
4747
size_targc=1;
4848
napi_valueargs[1];
4949
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -57,7 +57,7 @@ napi_value AsInt64(napi_env env, napi_callback_info info) {
5757
returnoutput;
5858
}
5959

60-
napi_valueAsDouble(napi_envenv, napi_callback_infoinfo) {
60+
staticnapi_valueAsDouble(napi_envenv, napi_callback_infoinfo) {
6161
size_targc=1;
6262
napi_valueargs[1];
6363
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -71,7 +71,7 @@ napi_value AsDouble(napi_env env, napi_callback_info info) {
7171
returnoutput;
7272
}
7373

74-
napi_valueAsString(napi_envenv, napi_callback_infoinfo) {
74+
staticnapi_valueAsString(napi_envenv, napi_callback_infoinfo) {
7575
size_targc=1;
7676
napi_valueargs[1];
7777
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -87,7 +87,7 @@ napi_value AsString(napi_env env, napi_callback_info info) {
8787
returnoutput;
8888
}
8989

90-
napi_valueToBool(napi_envenv, napi_callback_infoinfo) {
90+
staticnapi_valueToBool(napi_envenv, napi_callback_infoinfo) {
9191
size_targc=1;
9292
napi_valueargs[1];
9393
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -98,7 +98,7 @@ napi_value ToBool(napi_env env, napi_callback_info info) {
9898
returnoutput;
9999
}
100100

101-
napi_valueToNumber(napi_envenv, napi_callback_infoinfo) {
101+
staticnapi_valueToNumber(napi_envenv, napi_callback_infoinfo) {
102102
size_targc=1;
103103
napi_valueargs[1];
104104
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -109,7 +109,7 @@ napi_value ToNumber(napi_env env, napi_callback_info info) {
109109
returnoutput;
110110
}
111111

112-
napi_valueToObject(napi_envenv, napi_callback_infoinfo) {
112+
staticnapi_valueToObject(napi_envenv, napi_callback_infoinfo) {
113113
size_targc=1;
114114
napi_valueargs[1];
115115
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -120,7 +120,7 @@ napi_value ToObject(napi_env env, napi_callback_info info) {
120120
returnoutput;
121121
}
122122

123-
napi_valueToString(napi_envenv, napi_callback_infoinfo) {
123+
staticnapi_valueToString(napi_envenv, napi_callback_infoinfo) {
124124
size_targc=1;
125125
napi_valueargs[1];
126126
NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -131,7 +131,7 @@ napi_value ToString(napi_env env, napi_callback_info info) {
131131
returnoutput;
132132
}
133133

134-
napi_valueInit(napi_envenv, napi_valueexports) {
134+
staticnapi_valueInit(napi_envenv, napi_valueexports) {
135135
napi_property_descriptordescriptors[] = {
136136
DECLARE_NAPI_PROPERTY("asBool", AsBool),
137137
DECLARE_NAPI_PROPERTY("asInt32", AsInt32),

0 commit comments

Comments
 (0)