http2,zlib: prefer call() over apply() if argument list is not array

LiviaMedeiros · RafaelGSS · commit b2736646b6f7 · 2026-01-13T10:04:41.000-03:00
PR-URL: #60834 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -7,7 +7,6 @@ const {
 ObjectHasOwn,
 ObjectKeys,
 Proxy,
- ReflectApply,
 ReflectGetPrototypeOf,
 Symbol,
 } = primordials;
@@ -846,7 +845,7 @@ class Http2ServerResponse extends Stream {
 this.writeHead(this[kState].statusCode);
 
 if (this[kState].closed || stream.destroyed)
- ReflectApply(onStreamCloseResponse, stream, []);
+ onStreamCloseResponse.call(stream);
 else
 stream.end();
 
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -1960,7 +1960,7 @@ function shutdownWritable(callback) {
 req.handle = handle;
 const err = handle.shutdown(req);
 if (err === 1) // synchronous finish
- return ReflectApply(afterShutdown, req, [0]);
+ return afterShutdown.call(req, 0);
 }
 
 function finishSendTrailers(stream, headersList) {
@@ -2327,7 +2327,7 @@ class Http2Stream extends Duplex {
 return;
 }
 debugStreamObj(this, 'shutting down writable on _final');
- ReflectApply(shutdownWritable, this, [cb]);
+ shutdownWritable.call(this, cb);
 
 if (this.session[kType] === NGHTTP2_SESSION_CLIENT && onClientStreamBodySentChannel.hasSubscribers) {
 onClientStreamBodySentChannel.publish({ stream: this });
@@ -2741,8 +2741,7 @@ function doSendFD(session, options, fd, headers, streamOptions, err, stat) {
 // response is canceled. The user code may also send a separate type
 // of response so check again for the HEADERS_SENT flag
 if ((typeof options.statCheck === 'function' &&
- ReflectApply(options.statCheck, this,
- [stat, headers, statOptions]) === false) ||
+ options.statCheck.call(this, stat, headers, statOptions) === false) ||
 (this[kState].flags & STREAM_FLAGS_HEADERS_SENT)) {
 return;
 }
@@ -2801,7 +2800,7 @@ function doSendFileFD(session, options, fd, headers, streamOptions, err, stat) {
 // response is canceled. The user code may also send a separate type
 // of response so check again for the HEADERS_SENT flag
 if ((typeof options.statCheck === 'function' &&
- ReflectApply(options.statCheck, this, [stat, headers]) === false) ||
+ options.statCheck.call(this, stat, headers) === false) ||
 (this[kState].flags & STREAM_FLAGS_HEADERS_SENT)) {
 tryClose(fd);
 return;
@@ -3633,9 +3632,9 @@ function getUnpackedSettings(buf, options = kEmptyObject) {
 const settings = {};
 let offset = 0;
 while (offset < buf.length) {
- const id = ReflectApply(readUInt16BE, buf, [offset]);
+ const id = readUInt16BE.call(buf, offset);
 offset += 2;
- const value = ReflectApply(readUInt32BE, buf, [offset]);
+ const value = readUInt32BE.call(buf, offset);
 switch (id) {
 case NGHTTP2_SETTINGS_HEADER_TABLE_SIZE:
 settings.headerTableSize = value;
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -31,7 +31,6 @@ const {
 ObjectFreeze,
 ObjectKeys,
 ObjectSetPrototypeOf,
- ReflectApply,
 Symbol,
 Uint32Array,
 } = primordials;
@@ -255,7 +254,7 @@ function ZlibBase(opts, mode, handle, { flush, finishFlush, fullFlush }) {
 }
 }
 
- ReflectApply(Transform, this, [{ autoDestroy: true, ...opts }]);
+ Transform.call(this, { autoDestroy: true, ...opts });
 this[kError] = null;
 this.bytesWritten = 0;
 this._handle = handle;
@@ -681,7 +680,7 @@ function Zlib(opts, mode) {
 processCallback,
 dictionary);
 
- ReflectApply(ZlibBase, this, [opts, mode, handle, zlibDefaultOpts]);
+ ZlibBase.call(this, opts, mode, handle, zlibDefaultOpts);
 
 this._level = level;
 this._strategy = strategy;
@@ -724,7 +723,7 @@ function Deflate(opts) {
 if (!(this instanceof Deflate)) {
 return deprecateInstantiation(Deflate, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, DEFLATE]);
+ Zlib.call(this, opts, DEFLATE);
 }
 ObjectSetPrototypeOf(Deflate.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Deflate, Zlib);
@@ -733,7 +732,7 @@ function Inflate(opts) {
 if (!(this instanceof Inflate)) {
 return deprecateInstantiation(Inflate, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, INFLATE]);
+ Zlib.call(this, opts, INFLATE);
 }
 ObjectSetPrototypeOf(Inflate.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Inflate, Zlib);
@@ -742,7 +741,7 @@ function Gzip(opts) {
 if (!(this instanceof Gzip)) {
 return deprecateInstantiation(Gzip, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, GZIP]);
+ Zlib.call(this, opts, GZIP);
 }
 ObjectSetPrototypeOf(Gzip.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Gzip, Zlib);
@@ -751,7 +750,7 @@ function Gunzip(opts) {
 if (!(this instanceof Gunzip)) {
 return deprecateInstantiation(Gunzip, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, GUNZIP]);
+ Zlib.call(this, opts, GUNZIP);
 }
 ObjectSetPrototypeOf(Gunzip.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Gunzip, Zlib);
@@ -761,7 +760,7 @@ function DeflateRaw(opts) {
 if (!(this instanceof DeflateRaw)) {
 return deprecateInstantiation(DeflateRaw, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, DEFLATERAW]);
+ Zlib.call(this, opts, DEFLATERAW);
 }
 ObjectSetPrototypeOf(DeflateRaw.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(DeflateRaw, Zlib);
@@ -770,7 +769,7 @@ function InflateRaw(opts) {
 if (!(this instanceof InflateRaw)) {
 return deprecateInstantiation(InflateRaw, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, INFLATERAW]);
+ Zlib.call(this, opts, INFLATERAW);
 }
 ObjectSetPrototypeOf(InflateRaw.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(InflateRaw, Zlib);
@@ -779,7 +778,7 @@ function Unzip(opts) {
 if (!(this instanceof Unzip)) {
 return deprecateInstantiation(Unzip, 'DEP0184', opts);
 }
- ReflectApply(Zlib, this, [opts, UNZIP]);
+ Zlib.call(this, opts, UNZIP);
 }
 ObjectSetPrototypeOf(Unzip.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Unzip, Zlib);
@@ -837,7 +836,7 @@ function Brotli(opts, mode) {
 this._writeState = new Uint32Array(2);
 handle.init(brotliInitParamsArray, this._writeState, processCallback);
 
- ReflectApply(ZlibBase, this, [opts, mode, handle, brotliDefaultOpts]);
+ ZlibBase.call(this, opts, mode, handle, brotliDefaultOpts);
 }
 ObjectSetPrototypeOf(Brotli.prototype, Zlib.prototype);
 ObjectSetPrototypeOf(Brotli, Zlib);
@@ -846,7 +845,7 @@ function BrotliCompress(opts) {
 if (!(this instanceof BrotliCompress)) {
 return deprecateInstantiation(BrotliCompress, 'DEP0184', opts);
 }
- ReflectApply(Brotli, this, [opts, BROTLI_ENCODE]);
+ Brotli.call(this, opts, BROTLI_ENCODE);
 }
 ObjectSetPrototypeOf(BrotliCompress.prototype, Brotli.prototype);
 ObjectSetPrototypeOf(BrotliCompress, Brotli);
@@ -855,7 +854,7 @@ function BrotliDecompress(opts) {
 if (!(this instanceof BrotliDecompress)) {
 return deprecateInstantiation(BrotliDecompress, 'DEP0184', opts);
 }
- ReflectApply(Brotli, this, [opts, BROTLI_DECODE]);
+ Brotli.call(this, opts, BROTLI_DECODE);
 }
 ObjectSetPrototypeOf(BrotliDecompress.prototype, Brotli.prototype);
 ObjectSetPrototypeOf(BrotliDecompress, Brotli);

-Original file line number
+Diff line change
 req.handle=handle;
 consterr=handle.shutdown(req);
 if(err===1)// synchronous finish
 -returnReflectApply(afterShutdown,req,[0]);
 +returnafterShutdown.call(req,0);
+}
 functionfinishSendTrailers(stream,headersList){
 return;
+}
 debugStreamObj(this,'shutting down writable on _final');
 -ReflectApply(shutdownWritable,this,[cb]);
 +shutdownWritable.call(this,cb);
 if(this.session[kType]===NGHTTP2_SESSION_CLIENT&&onClientStreamBodySentChannel.hasSubscribers){
 onClientStreamBodySentChannel.publish({stream: this});
 // response is canceled. The user code may also send a separate type
 // of response so check again for the HEADERS_SENT flag
 if((typeofoptions.statCheck==='function'&&
 -ReflectApply(options.statCheck,this,
 -[stat,headers,statOptions])===false)||
 +options.statCheck.call(this,stat,headers,statOptions)===false)||
 (this[kState].flags&STREAM_FLAGS_HEADERS_SENT)){
 return;
+}
 // response is canceled. The user code may also send a separate type
 // of response so check again for the HEADERS_SENT flag
 if((typeofoptions.statCheck==='function'&&
 -ReflectApply(options.statCheck,this,[stat,headers])===false)||
 +options.statCheck.call(this,stat,headers)===false)||
 (this[kState].flags&STREAM_FLAGS_HEADERS_SENT)){
 tryClose(fd);
 return;
 constsettings={};
 letoffset=0;
 while(offset<buf.length){
 -constid=ReflectApply(readUInt16BE,buf,[offset]);
 +constid=readUInt16BE.call(buf,offset);
 offset+=2;
 -constvalue=ReflectApply(readUInt32BE,buf,[offset]);
 +constvalue=readUInt32BE.call(buf,offset);
 switch(id){
 caseNGHTTP2_SETTINGS_HEADER_TABLE_SIZE:
 settings.headerTableSize=value;
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ const {`
`31`	`31`	`ObjectFreeze,`
`32`	`32`	`ObjectKeys,`
`33`	`33`	`ObjectSetPrototypeOf,`
`34`		`- ReflectApply,`
`35`	`34`	`Symbol,`
`36`	`35`	`Uint32Array,`
`37`	`36`	`}=primordials;`
`@@ -255,7 +254,7 @@ function ZlibBase(opts, mode, handle, { flush, finishFlush, fullFlush }) {`
`255`	`254`	`}`
`256`	`255`	`}`
`257`	`256`
`258`		`-ReflectApply(Transform,this,[{autoDestroy: true, ...opts}]);`
	`257`	`+Transform.call(this,{autoDestroy: true, ...opts});`
`259`	`258`	`this[kError]=null;`
`260`	`259`	`this.bytesWritten=0;`
`261`	`260`	`this._handle=handle;`
`@@ -681,7 +680,7 @@ function Zlib(opts, mode) {`
`681`	`680`	`processCallback,`
`682`	`681`	`dictionary);`
`683`	`682`
`684`		`-ReflectApply(ZlibBase,this,[opts,mode,handle,zlibDefaultOpts]);`
	`683`	`+ZlibBase.call(this,opts,mode,handle,zlibDefaultOpts);`
`685`	`684`
`686`	`685`	`this._level=level;`
`687`	`686`	`this._strategy=strategy;`
`@@ -724,7 +723,7 @@ function Deflate(opts) {`
`724`	`723`	`if(!(thisinstanceofDeflate)){`
`725`	`724`	`returndeprecateInstantiation(Deflate,'DEP0184',opts);`
`726`	`725`	`}`
`727`		`-ReflectApply(Zlib,this,[opts,DEFLATE]);`
	`726`	`+Zlib.call(this,opts,DEFLATE);`
`728`	`727`	`}`
`729`	`728`	`ObjectSetPrototypeOf(Deflate.prototype,Zlib.prototype);`
`730`	`729`	`ObjectSetPrototypeOf(Deflate,Zlib);`
`@@ -733,7 +732,7 @@ function Inflate(opts) {`
`733`	`732`	`if(!(thisinstanceofInflate)){`
`734`	`733`	`returndeprecateInstantiation(Inflate,'DEP0184',opts);`
`735`	`734`	`}`
`736`		`-ReflectApply(Zlib,this,[opts,INFLATE]);`
	`735`	`+Zlib.call(this,opts,INFLATE);`
`737`	`736`	`}`
`738`	`737`	`ObjectSetPrototypeOf(Inflate.prototype,Zlib.prototype);`
`739`	`738`	`ObjectSetPrototypeOf(Inflate,Zlib);`
`@@ -742,7 +741,7 @@ function Gzip(opts) {`
`742`	`741`	`if(!(thisinstanceofGzip)){`
`743`	`742`	`returndeprecateInstantiation(Gzip,'DEP0184',opts);`
`744`	`743`	`}`
`745`		`-ReflectApply(Zlib,this,[opts,GZIP]);`
	`744`	`+Zlib.call(this,opts,GZIP);`
`746`	`745`	`}`
`747`	`746`	`ObjectSetPrototypeOf(Gzip.prototype,Zlib.prototype);`
`748`	`747`	`ObjectSetPrototypeOf(Gzip,Zlib);`
`@@ -751,7 +750,7 @@ function Gunzip(opts) {`
`751`	`750`	`if(!(thisinstanceofGunzip)){`
`752`	`751`	`returndeprecateInstantiation(Gunzip,'DEP0184',opts);`
`753`	`752`	`}`
`754`		`-ReflectApply(Zlib,this,[opts,GUNZIP]);`
	`753`	`+Zlib.call(this,opts,GUNZIP);`
`755`	`754`	`}`
`756`	`755`	`ObjectSetPrototypeOf(Gunzip.prototype,Zlib.prototype);`
`757`	`756`	`ObjectSetPrototypeOf(Gunzip,Zlib);`
`@@ -761,7 +760,7 @@ function DeflateRaw(opts) {`
`761`	`760`	`if(!(thisinstanceofDeflateRaw)){`
`762`	`761`	`returndeprecateInstantiation(DeflateRaw,'DEP0184',opts);`
`763`	`762`	`}`
`764`		`-ReflectApply(Zlib,this,[opts,DEFLATERAW]);`
	`763`	`+Zlib.call(this,opts,DEFLATERAW);`
`765`	`764`	`}`
`766`	`765`	`ObjectSetPrototypeOf(DeflateRaw.prototype,Zlib.prototype);`
`767`	`766`	`ObjectSetPrototypeOf(DeflateRaw,Zlib);`
`@@ -770,7 +769,7 @@ function InflateRaw(opts) {`
`770`	`769`	`if(!(thisinstanceofInflateRaw)){`
`771`	`770`	`returndeprecateInstantiation(InflateRaw,'DEP0184',opts);`
`772`	`771`	`}`
`773`		`-ReflectApply(Zlib,this,[opts,INFLATERAW]);`
	`772`	`+Zlib.call(this,opts,INFLATERAW);`
`774`	`773`	`}`
`775`	`774`	`ObjectSetPrototypeOf(InflateRaw.prototype,Zlib.prototype);`
`776`	`775`	`ObjectSetPrototypeOf(InflateRaw,Zlib);`
`@@ -779,7 +778,7 @@ function Unzip(opts) {`
`779`	`778`	`if(!(thisinstanceofUnzip)){`
`780`	`779`	`returndeprecateInstantiation(Unzip,'DEP0184',opts);`
`781`	`780`	`}`
`782`		`-ReflectApply(Zlib,this,[opts,UNZIP]);`
	`781`	`+Zlib.call(this,opts,UNZIP);`
`783`	`782`	`}`
`784`	`783`	`ObjectSetPrototypeOf(Unzip.prototype,Zlib.prototype);`
`785`	`784`	`ObjectSetPrototypeOf(Unzip,Zlib);`
`@@ -837,7 +836,7 @@ function Brotli(opts, mode) {`
`837`	`836`	`this._writeState=newUint32Array(2);`
`838`	`837`	`handle.init(brotliInitParamsArray,this._writeState,processCallback);`
`839`	`838`
`840`		`-ReflectApply(ZlibBase,this,[opts,mode,handle,brotliDefaultOpts]);`
	`839`	`+ZlibBase.call(this,opts,mode,handle,brotliDefaultOpts);`
`841`	`840`	`}`
`842`	`841`	`ObjectSetPrototypeOf(Brotli.prototype,Zlib.prototype);`
`843`	`842`	`ObjectSetPrototypeOf(Brotli,Zlib);`
`@@ -846,7 +845,7 @@ function BrotliCompress(opts) {`
`846`	`845`	`if(!(thisinstanceofBrotliCompress)){`
`847`	`846`	`returndeprecateInstantiation(BrotliCompress,'DEP0184',opts);`
`848`	`847`	`}`
`849`		`-ReflectApply(Brotli,this,[opts,BROTLI_ENCODE]);`
	`848`	`+Brotli.call(this,opts,BROTLI_ENCODE);`
`850`	`849`	`}`
`851`	`850`	`ObjectSetPrototypeOf(BrotliCompress.prototype,Brotli.prototype);`
`852`	`851`	`ObjectSetPrototypeOf(BrotliCompress,Brotli);`
`@@ -855,7 +854,7 @@ function BrotliDecompress(opts) {`
`855`	`854`	`if(!(thisinstanceofBrotliDecompress)){`
`856`	`855`	`returndeprecateInstantiation(BrotliDecompress,'DEP0184',opts);`
`857`	`856`	`}`
`858`		`-ReflectApply(Brotli,this,[opts,BROTLI_DECODE]);`
	`857`	`+Brotli.call(this,opts,BROTLI_DECODE);`
`859`	`858`	`}`
`860`	`859`	`ObjectSetPrototypeOf(BrotliDecompress.prototype,Brotli.prototype);`
`861`	`860`	`ObjectSetPrototypeOf(BrotliDecompress,Brotli);`