util: fix inspection of module namespaces

PR-URL: #20962
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: devsnek

lib/util.js

@@ -488,7 +488,23 @@ function formatValue(ctx, value, recurseTimes) {
 if(ctx.showHidden){
 keys=Object.getOwnPropertyNames(value);
 }else{
-keys=Object.keys(value);
+// This might throw if `value` is a Module Namespace Object from an
+// unevaluated module, but we don't want to perform the actual type
+// check because it's expensive.
+// TODO(devsnek): track https://github.com/tc39/ecma262/issues/1209
+// and modify this logic as needed.
+try{
+keys=Object.keys(value);
+}catch(err){
+if(types.isNativeError(err)&&
+err.name==='ReferenceError'&&
+types.isModuleNamespaceObject(value)){
+keys=Object.getOwnPropertyNames(value);
+}else{
+throwerr;
+}
+}
+
 if(symbols.length!==0)
 symbols=symbols.filter((key)=>propertyIsEnumerable.call(value,key));
 }
@@ -782,7 +798,7 @@ function formatNamespaceObject(ctx, value, recurseTimes, keys) {
 try{
 output[i]=formatProperty(ctx,value,recurseTimes,keys[i],0);
 }catch(err){
-if(!(errinstanceofReferenceError)){
+if(!(types.isNativeError(err)&&err.name==='ReferenceError')){
 throwerr;
 }
 // Use the existing functionality. This makes sure the indentation and