timers: remove redundant unref calls

gioragutt · targos · commit b3ca1b358e4f · 2021-04-29T13:45:31.000+02:00
PR-URL: #38320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/timers/promises.js b/lib/timers/promises.js
@@ -61,8 +61,7 @@ function setTimeout(after, value, options = {}) {
 }
 let oncancel;
 const ret = new Promise((resolve, reject) => {
- const timeout = new Timeout(resolve, after, args, false, true);
- if (!ref) timeout.unref();
+ const timeout = new Timeout(resolve, after, args, false, ref);
 insert(timeout, timeout._idleTimeout);
 if (signal) {
 oncancel = FunctionPrototypeBind(cancelListenerHandler,
@@ -141,8 +140,7 @@ async function* setInterval(after, value, options = {}) {
 callback();
 callback = undefined;
 }
- }, after, undefined, true, true);
- if (!ref) interval.unref();
+ }, after, undefined, true, ref);
 insert(interval, interval._idleTimeout);
 if (signal) {
 onCancel = () => {

-Original file line number
+Diff line change
+}
 letoncancel;
 constret=newPromise((resolve,reject)=>{
 -consttimeout=newTimeout(resolve,after,args,false,true);
 -if(!ref)timeout.unref();
 +consttimeout=newTimeout(resolve,after,args,false,ref);
 insert(timeout,timeout._idleTimeout);
 if(signal){
 oncancel=FunctionPrototypeBind(cancelListenerHandler,
 callback();
 callback=undefined;
+}
 -},after,undefined,true,true);
 -if(!ref)interval.unref();
 +},after,undefined,true,ref);
 insert(interval,interval._idleTimeout);
 if(signal){
 onCancel=()=>{