util: determine object types in C++

Determine object types of regular expressions, Dates, Maps, and
Sets in the C++ layer instead of depending on toString()
behavior in JavaScript.
PR-URL: #4100
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Author: cjihrig

lib/util.js

@@ -6,7 +6,6 @@ const internalUtil = require('internal/util');
 constbinding=process.binding('util');
 
 constisError=internalUtil.isError;
-constobjectToString=internalUtil.objectToString;
 
 varDebug;
 
@@ -305,7 +304,7 @@ function formatValue(ctx, value, recurseTimes) {
 braces=['[',']'];
 empty=value.length===0;
 formatter=formatArray;
-}elseif(objectToString(value)==='[object Set]'){
+}elseif(binding.isSet(value)){
 braces=['{','}'];
 // With `showHidden`, `length` will display as a hidden property for
 // arrays. For consistency's sake, do the same for `size`, even though this
@@ -314,7 +313,7 @@ function formatValue(ctx, value, recurseTimes) {
 keys.unshift('size');
 empty=value.size===0;
 formatter=formatSet;
-}elseif(objectToString(value)==='[object Map]'){
+}elseif(binding.isMap(value)){
 braces=['{','}'];
 // Ditto.
 if(ctx.showHidden)
@@ -673,7 +672,7 @@ function isUndefined(arg) {
 exports.isUndefined=isUndefined;
 
 functionisRegExp(re){
-returnobjectToString(re)==='[object RegExp]';
+returnbinding.isRegExp(re);
 }
 exports.isRegExp=isRegExp;
 
@@ -683,7 +682,7 @@ function isObject(arg) {
 exports.isObject=isObject;
 
 functionisDate(d){
-returnobjectToString(d)==='[object Date]';
+returnbinding.isDate(d);
 }
 exports.isDate=isDate;
 

src/node_util.cc

@@ -13,12 +13,37 @@ using v8::Object;
 using v8::String;
 using v8::Value;
 
+
+staticvoidIsRegExp(const FunctionCallbackInfo<Value>& args) {
+CHECK_EQ(1, args.Length());
+ args.GetReturnValue().Set(args[0]->IsRegExp());
+}
+
+
+staticvoidIsDate(const FunctionCallbackInfo<Value>& args) {
+CHECK_EQ(1, args.Length());
+ args.GetReturnValue().Set(args[0]->IsDate());
+}
+
+
+staticvoidIsMap(const FunctionCallbackInfo<Value>& args) {
+CHECK_EQ(1, args.Length());
+ args.GetReturnValue().Set(args[0]->IsMap());
+}
+
+
 staticvoidIsMapIterator(const FunctionCallbackInfo<Value>& args) {
 CHECK_EQ(1, args.Length());
  args.GetReturnValue().Set(args[0]->IsMapIterator());
 }
 
 
+staticvoidIsSet(const FunctionCallbackInfo<Value>& args) {
+CHECK_EQ(1, args.Length());
+ args.GetReturnValue().Set(args[0]->IsSet());
+}
+
+
 staticvoidIsSetIterator(const FunctionCallbackInfo<Value>& args) {
 CHECK_EQ(1, args.Length());
  args.GetReturnValue().Set(args[0]->IsSetIterator());
@@ -50,7 +75,11 @@ void Initialize(Local<Object> target,
  Local<Value> unused,
  Local<Context> context) {
  Environment* env = Environment::GetCurrent(context);
+ env->SetMethod(target, "isRegExp", IsRegExp);
+ env->SetMethod(target, "isDate", IsDate);
+ env->SetMethod(target, "isMap", IsMap);
  env->SetMethod(target, "isMapIterator", IsMapIterator);
+ env->SetMethod(target, "isSet", IsSet);
  env->SetMethod(target, "isSetIterator", IsSetIterator);
  env->SetMethod(target, "isPromise", IsPromise);
  env->SetMethod(target, "getHiddenValue", GetHiddenValue);