process: improve queueMicrotask performance

apapirovski · BridgeAR · commit b491eabff181 · 2019-06-17T21:12:11.000+02:00
Optimize the hot code paths of queueMicrotask by not creating unnecessary objects, not looking up properties on frozen primordials, etc. PR-URL: #28093 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/async_hooks.js b/lib/async_hooks.js
@@ -134,15 +134,16 @@ class AsyncResource {
 constructor(type, opts = {}) {
 validateString(type, 'type');
 
- if (typeof opts === 'number') {
- opts = { triggerAsyncId: opts, requireManualDestroy: false };
- } else if (opts.triggerAsyncId === undefined) {
- opts.triggerAsyncId = getDefaultTriggerAsyncId();
+ let triggerAsyncId = opts;
+ let requireManualDestroy = false;
+ if (typeof opts !== 'number') {
+ triggerAsyncId = opts.triggerAsyncId === undefined ?
+ getDefaultTriggerAsyncId() : opts.triggerAsyncId;
+ requireManualDestroy = !!opts.requireManualDestroy;
 }
 
 // Unlike emitInitScript, AsyncResource doesn't supports null as the
 // triggerAsyncId.
- const triggerAsyncId = opts.triggerAsyncId;
 if (!Number.isSafeInteger(triggerAsyncId) || triggerAsyncId < -1) {
 throw new ERR_INVALID_ASYNC_ID('triggerAsyncId', triggerAsyncId);
 }
@@ -151,15 +152,14 @@ class AsyncResource {
 this[async_id_symbol] = asyncId;
 this[trigger_async_id_symbol] = triggerAsyncId;
 
- // This prop name (destroyed) has to be synchronized with C++
- const destroyed = { destroyed: false };
- this[destroyedSymbol] = destroyed;
-
 if (initHooksExist()) {
 emitInit(asyncId, type, triggerAsyncId, this);
 }
 
- if (!opts.requireManualDestroy) {
+ if (!requireManualDestroy) {
+ // This prop name (destroyed) has to be synchronized with C++
+ const destroyed = { destroyed: false };
+ this[destroyedSymbol] = destroyed;
 registerDestroyHook(this, asyncId, destroyed);
 }
 }
@@ -168,14 +168,18 @@ class AsyncResource {
 const asyncId = this[async_id_symbol];
 emitBefore(asyncId, this[trigger_async_id_symbol]);
 try {
+ if (thisArg === undefined)
+ return fn(...args);
 return Reflect.apply(fn, thisArg, args);
 } finally {
 emitAfter(asyncId);
 }
 }
 
 emitDestroy() {
- this[destroyedSymbol].destroyed = true;
+ if (this[destroyedSymbol] !== undefined) {
+ this[destroyedSymbol].destroyed = true;
+ }
 emitDestroy(this[async_id_symbol]);
 return this;
 }
diff --git a/lib/internal/process/task_queues.js b/lib/internal/process/task_queues.js
@@ -128,15 +128,13 @@ function nextTick(callback) {
 }
 
 let AsyncResource;
+const defaultMicrotaskResourceOpts = { requireManualDestroy: true };
 function createMicrotaskResource() {
 // Lazy load the async_hooks module
- if (!AsyncResource) {
+ if (AsyncResource === undefined) {
 AsyncResource = require('async_hooks').AsyncResource;
 }
- return new AsyncResource('Microtask', {
- triggerAsyncId: getDefaultTriggerAsyncId(),
- requireManualDestroy: true,
- });
+ return new AsyncResource('Microtask', defaultMicrotaskResourceOpts);
 }
 
 function runMicrotask() {

-Original file line number
+Diff line change
 constructor(type,opts={}){
 validateString(type,'type');
 -if(typeofopts==='number'){
 -opts={triggerAsyncId: opts,requireManualDestroy: false};
 -}elseif(opts.triggerAsyncId===undefined){
 -opts.triggerAsyncId=getDefaultTriggerAsyncId();
 +lettriggerAsyncId=opts;
 +letrequireManualDestroy=false;
 +if(typeofopts!=='number'){
 +triggerAsyncId=opts.triggerAsyncId===undefined ?
 +getDefaultTriggerAsyncId() : opts.triggerAsyncId;
 +requireManualDestroy=!!opts.requireManualDestroy;
+}
 // Unlike emitInitScript, AsyncResource doesn't supports null as the
 // triggerAsyncId.
 -consttriggerAsyncId=opts.triggerAsyncId;
 if(!Number.isSafeInteger(triggerAsyncId)||triggerAsyncId<-1){
 thrownewERR_INVALID_ASYNC_ID('triggerAsyncId',triggerAsyncId);
+}
 this[async_id_symbol]=asyncId;
 this[trigger_async_id_symbol]=triggerAsyncId;
 -// This prop name (destroyed) has to be synchronized with C++
 -constdestroyed={destroyed: false};
 -this[destroyedSymbol]=destroyed;
+-
 if(initHooksExist()){
 emitInit(asyncId,type,triggerAsyncId,this);
+}
 -if(!opts.requireManualDestroy){
 +if(!requireManualDestroy){
 +// This prop name (destroyed) has to be synchronized with C++
 +constdestroyed={destroyed: false};
 +this[destroyedSymbol]=destroyed;
 registerDestroyHook(this,asyncId,destroyed);
+}
+}
 constasyncId=this[async_id_symbol];
 emitBefore(asyncId,this[trigger_async_id_symbol]);
 try{
 +if(thisArg===undefined)
 +returnfn(...args);
 returnReflect.apply(fn,thisArg,args);
 }finally{
 emitAfter(asyncId);
+}
+}
 emitDestroy(){
 -this[destroyedSymbol].destroyed=true;
 +if(this[destroyedSymbol]!==undefined){
 +this[destroyedSymbol].destroyed=true;
 +}
 emitDestroy(this[async_id_symbol]);
 returnthis;
+}
Original file line number	Diff line number	Diff line change
`@@ -128,15 +128,13 @@ function nextTick(callback) {`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`letAsyncResource;`
	`131`	`+constdefaultMicrotaskResourceOpts={requireManualDestroy: true};`
`131`	`132`	`functioncreateMicrotaskResource(){`
`132`	`133`	`// Lazy load the async_hooks module`
`133`		`-if(!AsyncResource){`
	`134`	`+if(AsyncResource===undefined){`
`134`	`135`	`AsyncResource=require('async_hooks').AsyncResource;`
`135`	`136`	`}`
`136`		`-returnnewAsyncResource('Microtask',{`
`137`		`-triggerAsyncId: getDefaultTriggerAsyncId(),`
`138`		`-requireManualDestroy: true,`
`139`		`-});`
	`137`	`+returnnewAsyncResource('Microtask',defaultMicrotaskResourceOpts);`
`140`	`138`	`}`
`141`	`139`
`142`	`140`	`functionrunMicrotask(){`