Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit b5182f0

Browse files
greenheadHQaduh95
authored andcommitted
lib: use validateArray for array arguments
Replace manual ArrayIsArray checks that throw ERR_INVALID_ARG_TYPE with the shared validateArray helper. The error code, argument name and expected type are unchanged, so the thrown error stays identical. Signed-off-by: greenhead <shren0812@gmail.com> PR-URL: #64959 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
1 parent 8f5f48a commit b5182f0

5 files changed

Lines changed: 12 additions & 26 deletions

File tree

‎lib/internal/streams/iter/broadcast.js‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const {
3333
}=require('internal/errors');
3434
const{
3535
validateAbortSignal,
36+
validateArray,
3637
validateInteger,
3738
validateObject,
3839
}=require('internal/validators');
@@ -559,9 +560,7 @@ class BroadcastWriter {
559560
}
560561

561562
writev(chunks,options){
562-
if(!ArrayIsArray(chunks)){
563-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
564-
}
563+
validateArray(chunks,'chunks');
565564
constsignal=getWriterSignal(options);
566565
// Fast path: no signal, writer open, buffer has space
567566
if(this.#canUseWriteFastPath(signal)){
@@ -620,9 +619,7 @@ class BroadcastWriter {
620619
}
621620

622621
writevSync(chunks){
623-
if(!ArrayIsArray(chunks)){
624-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
625-
}
622+
validateArray(chunks,'chunks');
626623
if(this.#isClosedOrAborted())returnfalse;
627624
if(!this.#broadcast[kCanWrite]())returnfalse;
628625
constconverted=convertChunks(chunks);

‎lib/internal/streams/iter/classic.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// toWritable(writer) -- stream/iter Writer -> classic Writable
1313

1414
const{
15-
ArrayIsArray,
1615
ArrayPrototypePush,
1716
NumberMAX_SAFE_INTEGER,
1817
Promise,
@@ -41,6 +40,7 @@ const {
4140
}=require('internal/errors');
4241

4342
const{
43+
validateArray,
4444
validateInteger,
4545
validateObject,
4646
}=require('internal/validators');
@@ -619,9 +619,7 @@ function fromWritable(writable, options = kNullPrototype) {
619619
},
620620

621621
writev(chunks,options){
622-
if(!ArrayIsArray(chunks)){
623-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
624-
}
622+
validateArray(chunks,'chunks');
625623
getWriterSignal(options);
626624
if(!isWritable()){
627625
returnPromiseReject(newERR_STREAM_WRITE_AFTER_END());

‎lib/internal/streams/iter/push.js‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
// with built-in backpressure.
77

88
const{
9-
ArrayIsArray,
109
ArrayPrototypePush,
1110
PromisePrototypeThen,
1211
PromiseReject,
@@ -21,13 +20,13 @@ const {
2120

2221
const{
2322
codes: {
24-
ERR_INVALID_ARG_TYPE,
2523
ERR_INVALID_STATE,
2624
},
2725
}=require('internal/errors');
2826
const{ lazyDOMException }=require('internal/util');
2927
const{
3028
validateAbortSignal,
29+
validateArray,
3130
validateInteger,
3231
}=require('internal/validators');
3332

@@ -629,9 +628,7 @@ class PushWriter {
629628
}
630629

631630
writev(chunks,options){
632-
if(!ArrayIsArray(chunks)){
633-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
634-
}
631+
validateArray(chunks,'chunks');
635632
constsignal=getWriterSignal(options);
636633
if(!signal&&this.#queue.canWriteSync()){
637634
constbytes=convertChunks(chunks);
@@ -648,9 +645,7 @@ class PushWriter {
648645
}
649646

650647
writevSync(chunks){
651-
if(!ArrayIsArray(chunks)){
652-
thrownewERR_INVALID_ARG_TYPE('chunks','Array',chunks);
653-
}
648+
validateArray(chunks,'chunks');
654649
constbytes=convertChunks(chunks);
655650
returnthis.#queue.writeSync(bytes);
656651
}

‎lib/internal/tls/secure-context.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const {
2626
}=require('internal/util/types');
2727

2828
const{
29+
validateArray,
2930
validateBuffer,
3031
validateInt32,
3132
validateObject,
@@ -212,10 +213,7 @@ function configSecureContext(context, options = kEmptyObject, name = 'options')
212213
}
213214

214215
if(certificateCompression!=null){
215-
if(!ArrayIsArray(certificateCompression)){
216-
thrownewERR_INVALID_ARG_TYPE(
217-
`${name}.certificateCompression`,'Array',certificateCompression);
218-
}
216+
validateArray(certificateCompression,`${name}.certificateCompression`);
219217

220218
if(certificateCompression.length>0){
221219
// Pack length + algorithm IDs into a single Uint32 for a cheap

‎lib/tls.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const { canonicalizeIP } = internalBinding('cares_wrap');
7070
consttlsCommon=require('internal/tls/common');
7171
consttlsWrap=require('internal/tls/wrap');
7272
const{ domainToASCII }=require('internal/url');
73-
const{ validateString }=require('internal/validators');
73+
const{validateArray,validateString }=require('internal/validators');
7474

7575
const{
7676
namespace: {
@@ -206,9 +206,7 @@ function getCACertificates(type = 'default') {
206206
exports.getCACertificates=getCACertificates;
207207

208208
functionsetDefaultCACertificates(certs){
209-
if(!ArrayIsArray(certs)){
210-
thrownewERR_INVALID_ARG_TYPE('certs','Array',certs);
211-
}
209+
validateArray(certs,'certs');
212210

213211
// Verify that all elements in the array are strings
214212
for(leti=0;i<certs.length;i++){

0 commit comments

Comments
 (0)