Revert "http2: avoid copying the options in respond()"

This reverts commit 3329647.
PR-URL: #64663
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Author: aduh95

lib/internal/http2/core.js

@@ -2654,35 +2654,31 @@ function prepareResponseHeaders(stream, headersParam, options) {
 functionprepareResponseHeadersObject(oldHeaders,options){
 assertIsObject(oldHeaders,'headers',['Object','Array']);
 constheaders={__proto__: null};
-letstatusCode;
-lethasDate=false;
 
 if(oldHeaders!==null&&oldHeaders!==undefined){
 // This loop is here for performance reason. Do not change.
-// The :status and date fields are picked up while copying so they do
-// not have to be looked up again on the null-prototype copy.
 for(constkeyinoldHeaders){
 if(ObjectHasOwn(oldHeaders,key)){
-constvalue=oldHeaders[key];
-headers[key]=value;
-if(key===HTTP2_HEADER_STATUS)
-statusCode=value;
-elseif(key===HTTP2_HEADER_DATE)
-hasDate=value!=null;
+headers[key]=oldHeaders[key];
 }
 }
 headers[kSensitiveHeaders]=oldHeaders[kSensitiveHeaders];
 }
 
-statusCode=headers[HTTP2_HEADER_STATUS]=statusCode|0||HTTP_STATUS_OK;
+conststatusCode=
+headers[HTTP2_HEADER_STATUS]=
+headers[HTTP2_HEADER_STATUS]|0||HTTP_STATUS_OK;
 
-if(!hasDate&&(options.sendDate==null||options.sendDate)){
-headers[HTTP2_HEADER_DATE]=utcDate();
+if(options.sendDate==null||options.sendDate){
+headers[HTTP2_HEADER_DATE]??=utcDate();
 }
 
 validatePreparedResponseHeaders(headers,statusCode);
 
-return{ headers, statusCode };
+return{
+ headers,
+statusCode: headers[HTTP2_HEADER_STATUS],
+};
 }
 
 functionprepareResponseHeadersArray(headers,options){
@@ -3051,17 +3047,15 @@ class ServerHttp2Stream extends Http2Stream {
 conststate=this[kState];
 
 assertIsObject(options,'options');
-// The options are only read, never mutated, so the user-provided object
-// can be used directly instead of copying it.
-options??=kEmptyObject;
+options={ ...options};
 
 debugStreamObj(this,'initiating response');
 this[kUpdateTimer]();
 
-constendStream=!!options.endStream;
+options.endStream=!!options.endStream;
 
 letstreamOptions=0;
-if(endStream)
+if(options.endStream)
 streamOptions|=STREAM_OPTION_EMPTY_PAYLOAD;
 
 if(options.waitForTrailers){
@@ -3079,11 +3073,12 @@ class ServerHttp2Stream extends Http2Stream {
 
 // Close the writable side if the endStream option is set or status
 // is one of known codes with no payload, or it's a head request
-if(endStream||
+if(!!options.endStream||
 statusCode===HTTP_STATUS_NO_CONTENT||
 statusCode===HTTP_STATUS_RESET_CONTENT||
 statusCode===HTTP_STATUS_NOT_MODIFIED||
 this.headRequest===true){
+options.endStream=true;
 this.end();
 }