fs: improve error performance of opendirSync

PR-URL: #49705
Refs: nodejs/performance#106
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: anonrig

benchmark/fs/bench-opendirSync.js

@@ -0,0 +1,43 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+constpath=require('path');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+consttestFiles=fs.readdirSync('test',{withFileTypes: true})
+.filter((f)=>f.isDirectory())
+.map((f)=>path.join(f.path,f.name));
+constbench=common.createBenchmark(main,{
+type: ['existing','non-existing'],
+n: [1e3],
+});
+
+functionmain({ n, type }){
+letfiles;
+
+switch(type){
+case'existing':
+files=testFiles;
+break;
+case'non-existing':
+files=[tmpdir.resolve(`.non-existing-file-${Date.now()}`)];
+break;
+default:
+newError('Invalid type');
+}
+
+bench.start();
+for(leti=0;i<n;i++){
+for(letj=0;j<files.length;j++){
+try{
+constdir=fs.opendirSync(files[j]);
+dir.closeSync();
+}catch{
+// do nothing
+}
+}
+}
+bench.end(n);
+}

lib/internal/fs/dir.js

@@ -322,18 +322,11 @@ function opendir(path, options, callback) {
 
 functionopendirSync(path,options){
 path=getValidatedPath(path);
-options=getOptions(options,{
-encoding: 'utf8',
-});
+options=getOptions(options,{encoding: 'utf8'});
 
-constctx={ path };
-consthandle=dirBinding.opendir(
+consthandle=dirBinding.opendirSync(
 pathModule.toNamespacedPath(path),
-options.encoding,
-undefined,
-ctx,
 );
-handleErrorFromBinding(ctx);
 
 returnnewDir(handle,path,options);
 }

src/node_dir.cc

@@ -397,6 +397,32 @@ static void OpenDir(const FunctionCallbackInfo<Value>& args) {
  }
 }
 
+staticvoidOpenDirSync(const FunctionCallbackInfo<Value>& args) {
+ Environment* env = Environment::GetCurrent(args);
+ Isolate* isolate = env->isolate();
+
+CHECK_GE(args.Length(), 1);
+
+ BufferValue path(isolate, args[0]);
+CHECK_NOT_NULL(*path);
+THROW_IF_INSUFFICIENT_PERMISSIONS(
+ env, permission::PermissionScope::kFileSystemRead, path.ToStringView());
+
+uv_fs_t req;
+auto make = OnScopeLeave([&req]() { uv_fs_req_cleanup(&req); });
+FS_DIR_SYNC_TRACE_BEGIN(opendir);
+int err = uv_fs_opendir(nullptr, &req, *path, nullptr);
+FS_DIR_SYNC_TRACE_END(opendir);
+if (err < 0) {
+return env->ThrowUVException(err, "opendir");
+ }
+
+uv_dir_t* dir = static_cast<uv_dir_t*>(req.ptr);
+ DirHandle* handle = DirHandle::New(env, dir);
+
+ args.GetReturnValue().Set(handle->object().As<Value>());
+}
+
 voidInitialize(Local<Object> target,
  Local<Value> unused,
  Local<Context> context,
@@ -405,6 +431,7 @@ void Initialize(Local<Object> target,
  Isolate* isolate = env->isolate();
 
 SetMethod(context, target, "opendir", OpenDir);
+SetMethod(context, target, "opendirSync", OpenDirSync);
 
 // Create FunctionTemplate for DirHandle
  Local<FunctionTemplate> dir = NewFunctionTemplate(isolate, DirHandle::New);
@@ -419,6 +446,7 @@ void Initialize(Local<Object> target,
 
 voidRegisterExternalReferences(ExternalReferenceRegistry* registry) {
  registry->Register(OpenDir);
+ registry->Register(OpenDirSync);
  registry->Register(DirHandle::New);
  registry->Register(DirHandle::Read);
  registry->Register(DirHandle::Close);