fs: replace checkPosition with validateInteger

PR-URL: #33277
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

Author: rickyes

lib/internal/fs/streams.js

@@ -3,8 +3,6 @@
 const{
  Array,
  MathMin,
- NumberIsInteger,
- NumberIsSafeInteger,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
  Symbol,
@@ -16,7 +14,7 @@ const {
 ERR_STREAM_DESTROYED
 }=require('internal/errors').codes;
 const{ deprecate }=require('internal/util');
-const{validateNumber}=require('internal/validators');
+const{validateInteger}=require('internal/validators');
 constfs=require('fs');
 const{ Buffer }=require('buffer');
 const{
@@ -47,19 +45,6 @@ function allocNewPool(poolSize) {
 pool.used=0;
 }
 
-// Check the `this.start` and `this.end` of stream.
-functioncheckPosition(pos,name){
-if(!NumberIsSafeInteger(pos)){
-validateNumber(pos,name);
-if(!NumberIsInteger(pos))
-thrownewERR_OUT_OF_RANGE(name,'an integer',pos);
-thrownewERR_OUT_OF_RANGE(name,'>= 0 and <= 2 ** 53 - 1',pos);
-}
-if(pos<0){
-thrownewERR_OUT_OF_RANGE(name,'>= 0 and <= 2 ** 53 - 1',pos);
-}
-}
-
 functionroundUpToMultipleOf8(n){
 return(n+7)&~7;// Align to 8 byte boundary.
 }
@@ -111,15 +96,15 @@ function ReadStream(path, options) {
 this[kIsPerformingIO]=false;
 
 if(this.start!==undefined){
-checkPosition(this.start,'start');
+validateInteger(this.start,'start',0);
 
 this.pos=this.start;
 }
 
 if(this.end===undefined){
 this.end=Infinity;
 }elseif(this.end!==Infinity){
-checkPosition(this.end,'end');
+validateInteger(this.end,'end',0);
 
 if(this.start!==undefined&&this.start>this.end){
 thrownewERR_OUT_OF_RANGE(
@@ -346,7 +331,7 @@ function WriteStream(path, options) {
 this[kIsPerformingIO]=false;
 
 if(this.start!==undefined){
-checkPosition(this.start,'start');
+validateInteger(this.start,'start',0);
 
 this.pos=this.start;
 }

test/parallel/test-file-write-stream3.js

@@ -182,10 +182,12 @@ const run_test_4 = common.mustCall(function() {
 constfn=()=>{
 fs.createWriteStream(filepath,{start: -5,flags: 'r+'});
 };
+// Verify the range of values using a common integer verifier.
+// Limit Number.MAX_SAFE_INTEGER
 consterr={
 code: 'ERR_OUT_OF_RANGE',
 message: 'The value of "start" is out of range. '+
-'It must be >= 0 and <= 2 ** 53 - 1. Received -5',
+`It must be >= 0 && <= ${Number.MAX_SAFE_INTEGER}. Received -5`,
 name: 'RangeError'
 };
 assert.throws(fn,err);
@@ -197,10 +199,13 @@ const run_test_5 = common.mustCall(function() {
 constfn=()=>{
 fs.createWriteStream(filepath,{start: 2**53,flags: 'r+'});
 };
+// Verify the range of values using a common integer verifier.
+// Limit Number.MAX_SAFE_INTEGER
 consterr={
 code: 'ERR_OUT_OF_RANGE',
 message: 'The value of "start" is out of range. It must be '+
-'>= 0 and <= 2 ** 53 - 1. Received 9_007_199_254_740_992',
+`>= 0 && <= ${Number.MAX_SAFE_INTEGER}. `+
+'Received 9_007_199_254_740_992',
 name: 'RangeError'
 };
 assert.throws(fn,err);