lib: avoid for of loop and remove unnecessary variable in zlib

MCprotein · targos · commit b79aeabc4dd7 · 2024-10-02T07:57:33.000+02:00
removed the unnecessary declaration of 'i' in the _final method scope and changed the for of loop to a for loop Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54258 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -361,11 +361,10 @@ ZlibBase.prototype._final = function(callback) {
 // Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
 // Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
 const flushiness = [];
-let i = 0;
 const kFlushFlagList = [Z_NO_FLUSH, Z_BLOCK, Z_PARTIAL_FLUSH,
 Z_SYNC_FLUSH, Z_FULL_FLUSH, Z_FINISH];
-for (const flushFlag of kFlushFlagList) {
- flushiness[flushFlag] = i++;
+for (let i = 0; i < kFlushFlagList.length; i++) {
+ flushiness[kFlushFlagList[i]] = i;
 }
 
 function maxFlush(a, b) {

-Original file line number
+Diff line change
 // Z_NO_FLUSH (< Z_TREES) < Z_BLOCK < Z_PARTIAL_FLUSH <
 // Z_SYNC_FLUSH < Z_FULL_FLUSH < Z_FINISH
 constflushiness=[];
 -leti=0;
 constkFlushFlagList=[Z_NO_FLUSH,Z_BLOCK,Z_PARTIAL_FLUSH,
 Z_SYNC_FLUSH,Z_FULL_FLUSH,Z_FINISH];
 -for(constflushFlagofkFlushFlagList){
 -flushiness[flushFlag]=i++;
 +for(leti=0;i<kFlushFlagList.length;i++){
 +flushiness[kFlushFlagList[i]]=i;
+}
 functionmaxFlush(a,b){