http2: make HTTP2ServerResponse more streams compliant

HTTP2ServerResponse.write would behave differently than
both http1 and streams. This PR makes it more compliant
with stream.Writable behaviour.
PR-URL: #30964
Refs: #29529
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: ronag

lib/internal/http2/compat.js

@@ -40,7 +40,8 @@ const {
 ERR_HTTP2_STATUS_INVALID,
 ERR_INVALID_ARG_VALUE,
 ERR_INVALID_CALLBACK,
-ERR_INVALID_HTTP_TOKEN
+ERR_INVALID_HTTP_TOKEN,
+ERR_STREAM_WRITE_AFTER_END
 },
  hideStackFrames
 }=require('internal/errors');
@@ -439,6 +440,7 @@ class Http2ServerResponse extends Stream {
 this[kState]={
 closed: false,
 ending: false,
+destroyed: false,
 headRequest: false,
 sendDate: true,
 statusCode: HTTP_STATUS_OK,
@@ -649,23 +651,32 @@ class Http2ServerResponse extends Stream {
 }
 
 write(chunk,encoding,cb){
+conststate=this[kState];
+
 if(typeofencoding==='function'){
 cb=encoding;
 encoding='utf8';
 }
 
-if(this[kState].closed){
-consterr=newERR_HTTP2_INVALID_STREAM();
+leterr;
+if(state.ending){
+err=newERR_STREAM_WRITE_AFTER_END();
+}elseif(state.closed){
+err=newERR_HTTP2_INVALID_STREAM();
+}elseif(state.destroyed){
+returnfalse;
+}
+
+if(err){
 if(typeofcb==='function')
 process.nextTick(cb,err);
-else
-throwerr;
-return;
+this.destroy(err);
+returnfalse;
 }
 
 conststream=this[kStream];
 if(!stream.headersSent)
-this.writeHead(this[kState].statusCode);
+this.writeHead(state.statusCode);
 returnstream.write(chunk,encoding,cb);
 }
 
@@ -712,8 +723,10 @@ class Http2ServerResponse extends Stream {
 }
 
 destroy(err){
-if(this[kState].closed)
+if(this[kState].destroyed)
 return;
+
+this[kState].destroyed=true;
 this[kStream].destroy(err);
 }
 

test/parallel/test-http2-compat-serverresponse-write.js

@@ -10,42 +10,64 @@ if (!hasCrypto)
 skip('missing crypto');
 const{ createServer, connect }=require('http2');
 constassert=require('assert');
-
-constserver=createServer();
-server.listen(0,mustCall(()=>{
-constport=server.address().port;
-consturl=`http://localhost:${port}`;
-constclient=connect(url,mustCall(()=>{
-constrequest=client.request();
-request.resume();
-request.on('end',mustCall());
-request.on('close',mustCall(()=>{
-client.close();
+{
+constserver=createServer();
+server.listen(0,mustCall(()=>{
+constport=server.address().port;
+consturl=`http://localhost:${port}`;
+constclient=connect(url,mustCall(()=>{
+constrequest=client.request();
+request.resume();
+request.on('end',mustCall());
+request.on('close',mustCall(()=>{
+client.close();
+}));
 }));
-}));
 
-server.once('request',mustCall((request,response)=>{
-// response.write() returns true
-assert(response.write('muahaha','utf8',mustCall()));
+server.once('request',mustCall((request,response)=>{
+// response.write() returns true
+assert(response.write('muahaha','utf8',mustCall()));
 
-response.stream.close(0,mustCall(()=>{
-response.on('error',mustNotCall());
+response.stream.close(0,mustCall(()=>{
+response.on('error',mustNotCall());
 
-// response.write() without cb returns error
-assert.throws(
-()=>{response.write('muahaha');},
-{
-name: 'Error',
-code: 'ERR_HTTP2_INVALID_STREAM',
-message: 'The stream has been destroyed'
-}
-);
+// response.write() without cb returns error
+response.write('muahaha',mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_HTTP2_INVALID_STREAM');
 
-// response.write() with cb returns falsy value
-assert(!response.write('muahaha',mustCall()));
+// response.write() with cb returns falsy value
+assert(!response.write('muahaha',mustCall()));
+
+client.destroy();
+server.close();
+}));
+}));
+}));
+}));
+}
+
+{
+// Http2ServerResponse.write ERR_STREAM_WRITE_AFTER_END
+constserver=createServer();
+server.listen(0,mustCall(()=>{
+constport=server.address().port;
+consturl=`http://localhost:${port}`;
+constclient=connect(url,mustCall(()=>{
+constrequest=client.request();
+request.resume();
+request.on('end',mustCall());
+request.on('close',mustCall(()=>{
+client.close();
+}));
+}));
 
-client.destroy();
-server.close();
+server.once('request',mustCall((request,response)=>{
+response.end();
+response.write('asd',mustCall((err)=>{
+assert.strictEqual(err.code,'ERR_STREAM_WRITE_AFTER_END');
+client.destroy();
+server.close();
+}));
 }));
 }));
-}));
+}