test: add check to test-fs-readfile-tostring-fail

richardlau · danielleadams · commit bb6787cb57c4 · 2022-07-25T21:43:40.000-04:00
Check that all of the bytes were written to the temporary file before reading it to catch the case where there is insufficient disk space. PR-URL: #43850 Refs: #43833 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/test/pummel/test-fs-readfile-tostring-fail.js b/test/pummel/test-fs-readfile-tostring-fail.js
@@ -25,13 +25,17 @@ stream.on('error', (err) => { throw err; });
 
 const size = kStringMaxLength / 200;
 const a = Buffer.alloc(size, 'a');
+let expectedSize = 0;
 
 for (let i = 0; i < 201; i++) {
- stream.write(a);
+ stream.write(a, (err) => { assert.ifError(err); });
+ expectedSize += a.length;
 }
 
 stream.end();
 stream.on('finish', common.mustCall(function() {
+ assert.strictEqual(stream.bytesWritten, expectedSize,
+ `${stream.bytesWritten} bytes written (expected ${expectedSize} bytes).`);
 fs.readFile(file, 'utf8', common.mustCall(function(err, buf) {
 assert.ok(err instanceof Error);
 if (err.message !== 'Array buffer allocation failed') {

-Original file line number
+Diff line change
 constsize=kStringMaxLength/200;
 consta=Buffer.alloc(size,'a');
 +letexpectedSize=0;
 for(leti=0;i<201;i++){
 -stream.write(a);
 +stream.write(a,(err)=>{assert.ifError(err);});
 +expectedSize+=a.length;
+}
 stream.end();
 stream.on('finish',common.mustCall(function(){
 +assert.strictEqual(stream.bytesWritten,expectedSize,
 +`${stream.bytesWritten} bytes written (expected ${expectedSize} bytes).`);
 fs.readFile(file,'utf8',common.mustCall(function(err,buf){
 assert.ok(errinstanceofError);
 if(err.message!=='Array buffer allocation failed'){