crypto: fix key handle extraction

PR-URL: #25562
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: tniessen

lib/internal/crypto/keys.js

@@ -215,7 +215,7 @@ function parsePrivateKeyEncoding(enc, keyType, objName) {
 
 functiongetKeyObjectHandle(key,isPublic,allowKeyObject){
 if(!allowKeyObject){
-returnnewERR_INVALID_ARG_TYPE(
+thrownewERR_INVALID_ARG_TYPE(
 'key',
 ['string','Buffer','TypedArray','DataView'],
 key

test/parallel/test-crypto-key-objects.js

@@ -58,6 +58,17 @@ const privatePem = fixtures.readSync('test_rsa_privkey.pem', 'ascii');
 assert(plaintext.equals(deciphered));
 }
 
+{
+// Passing an existing key object should throw.
+constpublicKey=createPublicKey(publicPem);
+common.expectsError(()=>createPublicKey(publicKey),{
+type: TypeError,
+code: 'ERR_INVALID_ARG_TYPE',
+message: 'The "key" argument must be one of type string, Buffer, '+
+'TypedArray, or DataView. Received type object'
+});
+}
+
 {
 constpublicKey=createPublicKey(publicPem);
 assert.strictEqual(publicKey.type,'public');