tools: enable linter in test/fixtures/test-runner/output

PR-URL: #57698
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>

Author: aduh95

eslint.config.mjs

@@ -1,3 +1,4 @@
+import{readdirSync}from'node:fs';
 importModulefrom'node:module';
 import{fileURLToPath,URL}from'node:url';
 
@@ -25,6 +26,12 @@ const { default: stylisticJs } = await importEslintTool('@stylistic/eslint-plugi
 
 nodeCore.RULES_DIR=fileURLToPath(newURL('./tools/eslint-rules',import.meta.url));
 
+functionfilterFilesInDir(dirpath,filterFn){
+returnreaddirSync(dirpath)
+.filter(filterFn)
+.map((f)=>`${dirpath}/${f}`);
+}
+
 // The Module._resolveFilename() monkeypatching is to make it so that ESLint is able to
 // dynamically load extra modules that we install with it.
 constModuleResolveFilename=Module._resolveFilename;
@@ -54,6 +61,14 @@ export default [
 'test/fixtures/*',
 '!test/fixtures/console',
 '!test/fixtures/eval',
+'!test/fixtures/test-runner',
+'test/fixtures/test-runner/*',
+'!test/fixtures/test-runner/output',
+ ...filterFilesInDir(
+'test/fixtures/test-runner/output',
+// Filtering tsc output files (i.e. if there a foo.ts, we ignore foo.js):
+(f,_,files)=>f.endsWith('js')&&files.includes(f.replace(/\.[cm]?js$/,'.ts')),
+),
 '!test/fixtures/v8',
 '!test/fixtures/vm',
 ]),

test/fixtures/test-runner/output/abort_hooks.js

@@ -5,8 +5,8 @@ describe('1 before describe', () => {
 constac=newAbortController();
 before(()=>{
 console.log('before');
-ac.abort()
-},{signal: ac.signal});
+ac.abort();
+},{signal: ac.signal});
 
 it('test 1',()=>{
 console.log('1.1');
@@ -20,8 +20,8 @@ describe('2 after describe', () => {
 constac=newAbortController();
 after(()=>{
 console.log('after');
-ac.abort()
-},{signal: ac.signal});
+ac.abort();
+},{signal: ac.signal});
 
 it('test 1',()=>{
 console.log('2.1');
@@ -35,8 +35,8 @@ describe('3 beforeEach describe', () => {
 constac=newAbortController();
 beforeEach(()=>{
 console.log('beforeEach');
-ac.abort()
-},{signal: ac.signal});
+ac.abort();
+},{signal: ac.signal});
 
 it('test 1',()=>{
 console.log('3.1');
@@ -50,8 +50,8 @@ describe('4 afterEach describe', () => {
 constac=newAbortController();
 afterEach(()=>{
 console.log('afterEach');
-ac.abort()
-},{signal: ac.signal});
+ac.abort();
+},{signal: ac.signal});
 
 it('test 1',()=>{
 console.log('4.1');

test/fixtures/test-runner/output/arbitrary-output-colored.js

@@ -8,5 +8,8 @@ const fixtures = require('../../../common/fixtures');
 consttest=fixtures.path('test-runner/output/arbitrary-output-colored-1.js');
 constreset=fixtures.path('test-runner/output/reset-color-depth.js');
 awaitonce(spawn(process.execPath,['-r',reset,'--test',test],{stdio: 'inherit'}),'exit');
-awaitonce(spawn(process.execPath,['-r',reset,'--test','--test-reporter','tap',test],{stdio: 'inherit'}),'exit');
+awaitonce(
+spawn(process.execPath,['-r',reset,'--test','--test-reporter','tap',test],{stdio: 'inherit'}),
+'exit',
+);
 })().then(common.mustCall());

test/fixtures/test-runner/output/arbitrary-output.js

@@ -5,16 +5,19 @@ const v8_reporter = require('internal/test_runner/reporter/v8-serializer');
 const{ Buffer }=require('buffer');
 
 
-(asyncfunction(){
+// eslint-disable-next-line node-core/async-iife-no-unused-result
+(asyncfunction(){
 constreported=v8_reporter([
-{type: "test:pass",data: {name: "test",nesting: 0,file: __filename,testNumber: 1,details: {duration_ms: 0}}}
+{
+type: 'test:pass',
+data: {name: 'test',nesting: 0,file: __filename,testNumber: 1,details: {duration_ms: 0}},
+},
 ]);
 
 forawait(constchunkofreported){
 process.stdout.write(chunk);
-process.stdout.write(Buffer.concat([Buffer.from("arbitrary - pre"),chunk]));
-process.stdout.write(Buffer.from("arbitrary - mid"));
-process.stdout.write(Buffer.concat([chunk,Buffer.from("arbitrary - post")]));
+process.stdout.write(Buffer.concat([Buffer.from('arbitrary - pre'),chunk]));
+process.stdout.write(Buffer.from('arbitrary - mid'));
+process.stdout.write(Buffer.concat([chunk,Buffer.from('arbitrary - post')]));
 }
 })();
-

test/fixtures/test-runner/output/assertion-color-tty.mjs

@@ -1,6 +1,6 @@
-importassertfrom'node:assert/strict'
-import{test}from'node:test'
+importassertfrom'node:assert/strict';
+import{test}from'node:test';
 
 test('failing assertion',()=>{
-assert.strictEqual('!Hello World','Hello World!')
-})
+assert.strictEqual('!Hello World','Hello World!');
+});

test/fixtures/test-runner/output/before-and-after-each-too-many-listeners.js

@@ -1,5 +1,5 @@
 'use strict';
-const{ beforeEach, afterEach, test}=require("node:test");
+const{ beforeEach, afterEach, test}=require('node:test');
 beforeEach(()=>{});
 afterEach(()=>{});
 

test/fixtures/test-runner/output/before-and-after-each-with-timeout-too-many-listeners.js

@@ -1,7 +1,7 @@
 'use strict';
-const{ beforeEach, afterEach, test}=require("node:test");
-beforeEach(()=>{},{timeout: 10000});
-afterEach(()=>{},{timeout: 10000});
+const{ beforeEach, afterEach, test}=require('node:test');
+beforeEach(()=>{},{timeout: 10000});
+afterEach(()=>{},{timeout: 10000});
 
 for(leti=1;i<=11;++i){
 test(`${i}`,()=>{});

test/fixtures/test-runner/output/coverage-width-100-uncovered-lines.mjs

@@ -1,8 +1,11 @@
 // Flags: --experimental-test-coverage
 // here we can't import common module as the coverage will be different based on the system
 // Unused imports are here in order to populate the coverage report
+// eslint-disable-next-line no-unused-vars
 import*asafrom'../coverage-snap/b.js';
+// eslint-disable-next-line no-unused-vars
 import*asbfrom'../coverage-snap/a.js';
+// eslint-disable-next-line no-unused-vars
 import*ascfrom'../coverage-snap/many-uncovered-lines.js';
 
 import{test}from'node:test';

test/fixtures/test-runner/output/coverage-width-100-uncovered-lines.snapshot

@@ -28,6 +28,6 @@ ok 1 - Coverage Print Fixed Width 100
 # output | | | | 
 # coverage-width-100-uncovered-lines.mjs | 100.00 | 100.00 | 100.00 | 
 # --------------------------------------------------------------------------------------------------
-# all files | 52.80 | 60.00 | 1.61 | 
+# all files | 53.13 | 60.00 | 1.61 | 
 # --------------------------------------------------------------------------------------------------
 # end of coverage report

test/fixtures/test-runner/output/coverage-width-100.mjs

@@ -1,7 +1,9 @@
 // Flags: --experimental-test-coverage
 // here we can't import common module as the coverage will be different based on the system
 // Unused imports are here in order to populate the coverage report
+// eslint-disable-next-line no-unused-vars
 import*asafrom'../coverage-snap/b.js';
+// eslint-disable-next-line no-unused-vars
 import*asbfrom'../coverage-snap/a.js';
 
 import{test}from'node:test';