Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit bc1e19b

Browse files
jazellyaduh95
authored andcommitted
fs: fix realpath of namespaced drive paths
The JavaScript realpath implementation probes a namespaced drive root through the fs binding. Windows path resolution drops the trailing separator from that probe, so lstat receives C: and reports EISDIR. Use the regular drive-root spelling only for the probe. Preserve the namespaced spelling for traversal and returned paths. Signed-off-by: Jason Zhang <xzha4350@gmail.com> PR-URL: #65378Fixes: #62446 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
1 parent f644853 commit bc1e19b

3 files changed

Lines changed: 97 additions & 4 deletions

File tree

β€Žlib/fs.jsβ€Ž

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3272,13 +3272,22 @@ function unwatchFile(filename, listener) {
32723272

32733273

32743274
letsplitRoot;
3275+
letgetRealpathRootLstatPath;
32753276
if(isWindows){
32763277
// Regex to find the device root on Windows (e.g. 'c:\\'), including trailing
32773278
// slash.
32783279
constsplitRootRe=/^(?:[a-zA-Z]:|[\\/]{2}[^\\/]+[\\/][^\\/]+)?[\\/]*/;
3280+
constnamespacedDriveRootRe=/^\\\\\?\\([a-zA-Z]:\\)$/;
32793281
splitRoot=functionsplitRoot(str){
32803282
returnSideEffectFreeRegExpPrototypeExec(splitRootRe,str)[0];
32813283
};
3284+
3285+
// The root probe is the only use of this path. Passing a namespaced drive
3286+
// root to the binding would lose its trailing separator during resolution.
3287+
getRealpathRootLstatPath=functiongetRealpathRootLstatPath(path){
3288+
constmatch=SideEffectFreeRegExpPrototypeExec(namespacedDriveRootRe,path);
3289+
returnmatch===null ? path : match[1];
3290+
};
32823291
}else{
32833292
splitRoot=functionsplitRoot(str){
32843293
for(leti=0;i<str.length;++i){
@@ -3287,6 +3296,7 @@ if (isWindows) {
32873296
}
32883297
returnstr;
32893298
};
3299+
32903300
}
32913301

32923302
functionencodeRealpathResult(result,options){
@@ -3368,7 +3378,8 @@ function realpathSync(p, options) {
33683378

33693379
// On windows, check that the root exists. On unix there is no need.
33703380
if(isWindows){
3371-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3381+
constout=binding.lstat(
3382+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
33723383
if(out===undefined){
33733384
return;
33743385
}
@@ -3453,7 +3464,8 @@ function realpathSync(p, options) {
34533464

34543465
// On windows, check that the root exists. On unix there is no need.
34553466
if(isWindows&&!knownHard.has(base)){
3456-
constout=binding.lstat(base,false,undefined,true/* throwIfNoEntry */);
3467+
constout=binding.lstat(
3468+
getRealpathRootLstatPath(base),false,undefined,true/* throwIfNoEntry */);
34573469
if(out===undefined){
34583470
return;
34593471
}
@@ -3537,7 +3549,7 @@ function realpath(p, options, callback) {
35373549

35383550
// On windows, check that the root exists. On unix there is no need.
35393551
if(isWindows&&!knownHard.has(base)){
3540-
fs.lstat(base,(err)=>{
3552+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
35413553
if(err)returncallback(err);
35423554
knownHard.add(base);
35433555
LOOP();
@@ -3626,7 +3638,7 @@ function realpath(p, options, callback) {
36263638

36273639
// On windows, check that the root exists. On unix there is no need.
36283640
if(isWindows&&!knownHard.has(base)){
3629-
fs.lstat(base,(err)=>{
3641+
fs.lstat(getRealpathRootLstatPath(base),(err)=>{
36303642
if(err)returncallback(err);
36313643
knownHard.add(base);
36323644
LOOP();

β€Žtest/es-module/test-esm-long-path-win.jsβ€Ž

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,24 @@ describe('long path on Windows', () => {
4747
tmpdir.refresh();
4848
});
4949

50+
it('runs an extended-length path as the entry point',async()=>{
51+
// The module loader resolves argv[1] through the JavaScript realpath
52+
// implementation before executing it.
53+
tmpdir.refresh();
54+
constentry=tmpdir.resolve('extended-entry.js');
55+
fs.writeFileSync(entry,'console.log("hello world");');
56+
57+
const{ code, signal, stderr, stdout }=awaitspawnPromisified(
58+
execPath,
59+
[path.toNamespacedPath(entry)],
60+
);
61+
62+
assert.strictEqual(stderr,'');
63+
assert.strictEqual(stdout.trim(),'hello world');
64+
assert.strictEqual(code,0);
65+
assert.strictEqual(signal,null);
66+
});
67+
5068
it('check long path in LegacyMainResolve - 1',()=>{
5169
// Module layout will be the following:
5270
// package.json
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.isWindows){
5+
common.skip('This test is Windows-specific.');
6+
}
7+
8+
// Verify that the JavaScript realpath implementation accepts namespaced drive
9+
// paths, including when a junction switches the walk back to a regular drive
10+
// path, and reports a missing entry instead of treating the drive as a file.
11+
12+
constassert=require('node:assert');
13+
constfs=require('node:fs');
14+
constpath=require('node:path');
15+
const{ test }=require('node:test');
16+
consttmpdir=require('../common/tmpdir');
17+
18+
tmpdir.refresh();
19+
20+
constentry=tmpdir.resolve('entry.js');
21+
constnamespacedEntry=path.toNamespacedPath(entry);
22+
constnamespacedMissing=path.toNamespacedPath(tmpdir.resolve('missing.js'));
23+
consttargetDir=tmpdir.resolve('target');
24+
consttargetEntry=path.join(targetDir,'entry.js');
25+
constjunctionDir=tmpdir.resolve('junction');
26+
constnamespacedJunctionEntry=path.toNamespacedPath(
27+
path.join(junctionDir,'entry.js'),
28+
);
29+
30+
fs.writeFileSync(entry,'');
31+
fs.mkdirSync(targetDir);
32+
fs.writeFileSync(targetEntry,'');
33+
fs.symlinkSync(targetDir,junctionDir,'junction');
34+
35+
functionassertNamespacedRealpath(result){
36+
assert.strictEqual(path.toNamespacedPath(result),namespacedEntry);
37+
}
38+
39+
test('fs.realpathSync resolves a namespaced drive path',()=>{
40+
assertNamespacedRealpath(fs.realpathSync(namespacedEntry));
41+
});
42+
43+
test('fs.realpathSync reports ENOENT for a missing namespaced drive path',()=>{
44+
assert.throws(()=>fs.realpathSync(namespacedMissing),{code: 'ENOENT'});
45+
});
46+
47+
test('fs.realpathSync resolves a namespaced path through a junction',()=>{
48+
assert.strictEqual(fs.realpathSync(namespacedJunctionEntry),targetEntry);
49+
});
50+
51+
test('fs.realpath resolves a namespaced drive path',(t,done)=>{
52+
fs.realpath(namespacedEntry,common.mustSucceed((result)=>{
53+
assertNamespacedRealpath(result);
54+
done();
55+
}));
56+
});
57+
58+
test('fs.realpath resolves a namespaced path through a junction',(t,done)=>{
59+
fs.realpath(namespacedJunctionEntry,common.mustSucceed((result)=>{
60+
assert.strictEqual(result,targetEntry);
61+
done();
62+
}));
63+
});

0 commit comments

Comments
Β (0)