report: disable js stack when no context is entered

There are no guarantees that the JS stack can be generated when no
context is entered.
PR-URL: #48495Fixes: nodejs/node-v8#250
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4582948
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Author: legendecas

src/node_report.cc

@@ -66,6 +66,7 @@ static void PrintJavaScriptErrorStack(JSONWriter* writer,
  Isolate* isolate,
  Local<Value> error,
 constchar* trigger);
+staticvoidPrintEmptyJavaScriptStack(JSONWriter* writer);
 staticvoidPrintJavaScriptStack(JSONWriter* writer,
  Isolate* isolate,
 constchar* trigger);
@@ -184,6 +185,10 @@ static void WriteNodeReport(Isolate* isolate,
 
 // Report V8 Heap and Garbage Collector information
 PrintGCStatistics(&writer, isolate);
+ } else {
+ writer.json_objectstart("javascriptStack");
+PrintEmptyJavaScriptStack(&writer);
+ writer.json_objectend(); // the end of 'javascriptStack'
  }
 
 // Report native stack backtrace
@@ -452,8 +457,9 @@ static void PrintEmptyJavaScriptStack(JSONWriter* writer) {
 staticvoidPrintJavaScriptStack(JSONWriter* writer,
  Isolate* isolate,
 constchar* trigger) {
-// Can not capture the stacktrace when the isolate is in a OOM state.
-if (!strcmp(trigger, "OOMError")) {
+// Can not capture the stacktrace when the isolate is in a OOM state or no
+// context is entered.
+if (!strcmp(trigger, "OOMError") || !isolate->InContext()) {
 PrintEmptyJavaScriptStack(writer);
 return;
  }

test/addons/report-api/test.js

@@ -9,7 +9,7 @@ const tmpdir = require('../../common/tmpdir');
 constbinding=path.resolve(__dirname,`./build/${common.buildType}/binding`);
 constaddon=require(binding);
 
-functionmyAddonMain(method,{hasIsolate, hasEnv }){
+functionmyAddonMain(method,{hasContext, hasEnv }){
 tmpdir.refresh();
 process.report.directory=tmpdir.path;
 
@@ -27,10 +27,10 @@ function myAddonMain(method, { hasIsolate, hasEnv }) {
 constcontent=require(report);
 
 // Check that the javascript stack is present.
-if(hasIsolate){
+if(hasContext){
 assert.strictEqual(content.javascriptStack.stack.findIndex((frame)=>frame.match('myAddonMain')),0);
 }else{
-assert.strictEqual(content.javascriptStack,undefined);
+assert.strictEqual(content.javascriptStack.message,'No stack.');
 }
 
 if(hasEnv){
@@ -45,9 +45,9 @@ const methods = [
 ['triggerReportNoIsolate',false,false],
 ['triggerReportEnv',true,true],
 ['triggerReportNoEnv',false,false],
-['triggerReportNoContext',true,false],
+['triggerReportNoContext',false,false],
 ['triggerReportNewContext',true,false],
 ];
-for(const[method,hasIsolate,hasEnv]ofmethods){
-myAddonMain(method,{hasIsolate, hasEnv });
+for(const[method,hasContext,hasEnv]ofmethods){
+myAddonMain(method,{hasContext, hasEnv });
 }

test/common/report.js

@@ -55,19 +55,19 @@ function validateContent(report, fields = []) {
 
 function_validateContent(report,fields=[]){
 constisWindows=process.platform==='win32';
-constisJavaScriptThreadReport=report.javascriptStack!=null;
+constisJavaScriptThreadReport=report.javascriptHeap!=null;
 
 // Verify that all sections are present as own properties of the report.
-constsections=['header','nativeStack','libuv','environmentVariables',
-'sharedObjects','resourceUsage','workers'];
+constsections=['header','nativeStack','javascriptStack','libuv',
+'environmentVariables','sharedObjects','resourceUsage','workers'];
 if(!isWindows)
 sections.push('userLimits');
 
 if(report.uvthreadResourceUsage)
 sections.push('uvthreadResourceUsage');
 
 if(isJavaScriptThreadReport)
-sections.push('javascriptStack','javascriptHeap');
+sections.push('javascriptHeap');
 
 checkForUnknownFields(report,sections);
 sections.forEach((section)=>{