test: update test expectations for OpenSSL 1.1.0

Some errors in the two versions are different. The test-tls-no-sslv3 one
because OpenSSL 1.1.x finally does version negotiation properly. 1.0.x's
logic was somewhat weird and resulted in very inconsistent errors for
SSLv3 in particular.
Also the function codes are capitalized differently, but function codes
leak implementation details, so don't assert on them to begin with.
PR-URL: #16130
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>

Author: davidben

test/parallel/test-crypto.js

@@ -238,7 +238,7 @@ assert.throws(function() {
 // Throws crypto error, so there is an opensslErrorStack property.
 // The openSSL stack should have content.
 if((errinstanceofError)&&
-/asn1encodingroutines:ASN1_CHECK_TLEN:wrongtag/.test(err)&&
+/asn1encodingroutines:[^:]*:wrongtag/.test(err)&&
 err.opensslErrorStack!==undefined&&
 Array.isArray(err.opensslErrorStack)&&
 err.opensslErrorStack.length>0){

test/parallel/test-tls-junk-server.js

@@ -21,7 +21,9 @@ server.listen(0, function() {
 req.end();
 
 req.once('error',common.mustCall(function(err){
-assert(/unknownprotocol/.test(err.message));
+// OpenSSL 1.0.x and 1.1.x use different error messages for junk inputs.
+assert(/unknownprotocol/.test(err.message)||
+/wrongversionnumber/.test(err.message));
 server.close();
 }));
 });

test/parallel/test-tls-no-sslv3.js

@@ -46,6 +46,8 @@ process.on('exit', function() {
 common.printSkipMessage('`openssl s_client -ssl3` not supported.');
 }else{
 assert.strictEqual(errors.length,1);
-assert(/:wrongversionnumber/.test(errors[0].message));
+// OpenSSL 1.0.x and 1.1.x report invalid client versions differently.
+assert(/:wrongversionnumber/.test(errors[0].message)||
+/:versiontoolow/.test(errors[0].message));
 }
 });

test/parallel/test-tls-server-failed-handshake-emits-clienterror.js

@@ -20,8 +20,10 @@ const server = tls.createServer({})
 }).on('tlsClientError',common.mustCall(function(e){
 assert.ok(einstanceofError,
 'Instance of Error should be passed to error handler');
+// OpenSSL 1.0.x and 1.1.x use different error codes for junk inputs.
 assert.ok(
-/SSLroutines:SSL23_GET_CLIENT_HELLO:unknownprotocol/.test(e.message),
+/SSLroutines:[^:]*:(unknownprotocol|wrongversionnumber)/.test(
+e.message),
 'Expecting SSL unknown protocol');
 
 server.close();

test/parallel/test-tls-socket-failed-handshake-emits-error.js

@@ -20,8 +20,10 @@ const server = net.createServer(function(c) {
 s.on('error',common.mustCall(function(e){
 assert.ok(einstanceofError,
 'Instance of Error should be passed to error handler');
+// OpenSSL 1.0.x and 1.1.x use different error codes for junk inputs.
 assert.ok(
-/SSLroutines:SSL23_GET_CLIENT_HELLO:unknownprotocol/.test(e.message),
+/SSLroutines:[^:]*:(unknownprotocol|wrongversionnumber)/.test(
+e.message),
 'Expecting SSL unknown protocol');
 }));