http: improve for-loop readability in _http_outgoing.js

gengjiawen · BridgeAR · commit bf7a52b7648e · 2019-03-14T11:02:36.000+01:00
PR-URL: #26408 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -295,21 +295,21 @@ function _storeHeader(firstLine, headers) {
 header: firstLine
 };
 
- var key;
- if (headers === this[outHeadersKey]) {
- for (key in headers) {
- const entry = headers[key];
- processHeader(this, state, entry[0], entry[1], false);
- }
- } else if (Array.isArray(headers)) {
- for (var i = 0; i < headers.length; i++) {
- const entry = headers[i];
- processHeader(this, state, entry[0], entry[1], true);
- }
- } else if (headers) {
- for (key in headers) {
- if (hasOwnProperty(headers, key)) {
- processHeader(this, state, key, headers[key], true);
+ if (headers) {
+ if (headers === this[outHeadersKey]) {
+ for (const key in headers) {
+ const entry = headers[key];
+ processHeader(this, state, entry[0], entry[1], false);
+ }
+ } else if (Array.isArray(headers)) {
+ for (const entry of headers) {
+ processHeader(this, state, entry[0], entry[1], true);
+ }
+ } else {
+ for (const key in headers) {
+ if (hasOwnProperty(headers, key)) {
+ processHeader(this, state, key, headers[key], true);
+ }
 }
 }
 }

-Original file line number
+Diff line change
 header: firstLine
 };
 -varkey;
 -if(headers===this[outHeadersKey]){
 -for(keyinheaders){
 -constentry=headers[key];
 -processHeader(this,state,entry[0],entry[1],false);
 -}
 -}elseif(Array.isArray(headers)){
 -for(vari=0;i<headers.length;i++){
 -constentry=headers[i];
 -processHeader(this,state,entry[0],entry[1],true);
 -}
 -}elseif(headers){
 -for(keyinheaders){
 -if(hasOwnProperty(headers,key)){
 -processHeader(this,state,key,headers[key],true);
 +if(headers){
 +if(headers===this[outHeadersKey]){
 +for(constkeyinheaders){
 +constentry=headers[key];
 +processHeader(this,state,entry[0],entry[1],false);
 +}
 +}elseif(Array.isArray(headers)){
 +for(constentryofheaders){
 +processHeader(this,state,entry[0],entry[1],true);
 +}
 +}else{
 +for(constkeyinheaders){
 +if(hasOwnProperty(headers,key)){
 +processHeader(this,state,key,headers[key],true);
 +}
+}
+}
+}