tools: refactor checkimports.py

- Use f-strings for formatting.
- Use raw strings for regexes alongside f-strings.
- Use a generator.
- Remove unnecessary `else` clause.
PR-URL: #50011
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>

Author: VoltrexKeyva

tools/checkimports.py

@@ -8,9 +8,9 @@
 importitertools
 
 defdo_exist(file_name, lines, imported):
-ifnotany(notre.match('using \w+::{0};'.format(imported), line) and
-re.search('\\b{0}\\b'.format(imported), line) forlineinlines):
-print('File "{0}" does not use "{1}"'.format(file_name, imported))
+ifnotany(notre.match(fr'using \w+::{imported};', line) and
+re.search(fr'\b{imported}\b', line) forlineinlines):
+print(f'File "{file_name}" does not use "{imported}"')
 returnFalse
 returnTrue
 
@@ -27,18 +27,16 @@ def is_valid(file_name):
 usings.append(matches.group(1))
 importeds.append(matches.group(2))
 
-valid=all([do_exist(file_name, lines, imported) forimportedinimporteds])
+valid=all(do_exist(file_name, lines, imported) forimportedinimporteds)
 
 sorted_usings=sorted(usings, key=lambdax: x.lower())
 ifsorted_usings!=usings:
-print("using statements aren't sorted in '{0}'.".format(file_name))
+print(f"using statements aren't sorted in '{file_name}'.")
 fornum, actual, expectedinzip(line_numbers, usings, sorted_usings):
 ifactual!=expected:
-print('\tLine {0}: Actual: {1}, Expected: {2}'
- .format(num, actual, expected))
+print(f'\tLine {num}: Actual: {actual}, Expected: {expected}')
 returnFalse
-else:
-returnvalid
+returnvalid
 
 if__name__=='__main__':
 iflen(sys.argv) >1: