test: fix test-https-agent-additional-options

test-https-agent-additional-options can occasionally fail if a socket
closes before the checks near the end of the test. Modify the test to
check the freeSockets pool after each request.
PR-URL: #27830Fixes: #24449
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: Trott

test/parallel/test-https-agent-additional-options.js

@@ -39,41 +39,35 @@ const updatedValues = new Map([
 ['sessionIdContext','sessionIdContext'],
 ]);
 
+letvalue;
 functionvariations(iter,port,cb){
-const{ done, value }=iter.next();
-if(done){
-returncommon.mustCall((res)=>{
-res.resume();
-https.globalAgent.once('free',common.mustCall(()=>{
-// Verify that different keep-alived connections are created
-// for the base call and each variation
-constkeys=Object.keys(https.globalAgent.freeSockets);
-assert.strictEqual(keys.length,1+updatedValues.size);
-leti=1;
-for(const[,value]ofupdatedValues){
-assert.ok(
-keys[i].startsWith(value.toString()+':')||
-keys[i].endsWith(':'+value.toString())||
-keys[i].includes(':'+value.toString()+':')
-);
-i++;
-}
+returncommon.mustCall((res)=>{
+res.resume();
+https.globalAgent.once('free',common.mustCall(()=>{
+// Verify that the most recent connection is in the freeSockets pool.
+constkeys=Object.keys(https.globalAgent.freeSockets);
+if(value){
+assert.ok(
+keys.some((val)=>val.startsWith(value.toString()+':')||
+val.endsWith(':'+value.toString())||
+val.includes(':'+value.toString()+':')),
+`missing value: ${value.toString()} in ${keys}`
+);
+}
+constnext=iter.next();
+
+if(next.done){
 https.globalAgent.destroy();
 server.close();
-}));
-});
-}else{
-const[key,val]=value;
-returncommon.mustCall((res)=>{
-res.resume();
-https.globalAgent.once('free',common.mustCall(()=>{
-https.get(
-Object.assign({},getBaseOptions(port),{[key]: val}),
-variations(iter,port,cb)
-);
-}));
-});
-}
+}else{
+// Save `value` for check the next time.
+value=next.value.val;
+const[key,val]=next.value;
+https.get(Object.assign({},getBaseOptions(port),{[key]: val}),
+variations(iter,port,cb));
+}
+}));
+});
 }
 
 server.listen(0,common.mustCall(()=>{