lib: replace spread operator with primordials function

MCprotein · targos · commit c004abaf1736 · 2024-10-02T07:57:34.000+02:00
replaced the spread operator with ArrayPrototypeSlice to avoid reliance on user-mutable methods and enhance the safety of array iteration Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration PR-URL: #54053 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
diff --git a/lib/internal/streams/compose.js b/lib/internal/streams/compose.js
@@ -1,5 +1,9 @@
 'use strict';
 
+const {
+ ArrayPrototypeSlice,
+} = primordials;
+
 const { pipeline } = require('internal/streams/pipeline');
 const Duplex = require('internal/streams/duplex');
 const { destroyer } = require('internal/streams/destroy');
@@ -30,7 +34,7 @@ module.exports = function compose(...streams) {
 return Duplex.from(streams[0]);
 }
 
- const orgStreams = [...streams];
+ const orgStreams = ArrayPrototypeSlice(streams);
 
 if (typeof streams[0] === 'function') {
 streams[0] = Duplex.from(streams[0]);

-Original file line number
+Diff line change
@@ @@ -1,5 +1,9 @@ @@
 'use strict';
 +const{
 + ArrayPrototypeSlice,
 +}=primordials;
++
 const{ pipeline }=require('internal/streams/pipeline');
 constDuplex=require('internal/streams/duplex');
 const{ destroyer }=require('internal/streams/destroy');
 returnDuplex.from(streams[0]);
+}
 -constorgStreams=[...streams];
 +constorgStreams=ArrayPrototypeSlice(streams);
 if(typeofstreams[0]==='function'){
 streams[0]=Duplex.from(streams[0]);