inspector: inspect HTTP response body

PR-URL: #60572
Refs: #53946
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Author: legendecas

lib/internal/inspector/network_http.js

@@ -17,6 +17,7 @@ const {
  sniffMimeType,
 }=require('internal/inspector/network');
 const{ Network }=require('inspector');
+constEventEmitter=require('events');
 
 constkRequestUrl=Symbol('kRequestUrl');
 
@@ -120,6 +121,17 @@ function onClientResponseFinish({ request, response }) {
 },
 });
 
+// Unlike response.on('data', ...), this does not put the stream into flowing mode.
+EventEmitter.prototype.on.call(response,'data',(chunk)=>{
+Network.dataReceived({
+requestId: request[kInspectorRequestId],
+timestamp: getMonotonicTime(),
+dataLength: chunk.byteLength,
+encodedDataLength: chunk.byteLength,
+data: chunk,
+});
+});
+
 // Wait until the response body is consumed by user code.
 response.once('end',()=>{
 Network.loadingFinished({

test/parallel/test-inspector-network-http.js

@@ -130,6 +130,27 @@ function verifyLoadingFailed({ method, params }) {
 assert.strictEqual(typeofparams.errorText,'string');
 }
 
+functionverifyHttpResponse(response){
+assert.strictEqual(response.statusCode,200);
+constchunks=[];
+
+// Verifies that the inspector does not put the response into flowing mode.
+assert.strictEqual(response.readableFlowing,null);
+// Verifies that the data listener may be added at a later time, and it can
+// still observe the data in full.
+queueMicrotask(()=>{
+response.on('data',(chunk)=>{
+chunks.push(chunk);
+});
+assert.strictEqual(response.readableFlowing,true);
+});
+
+response.on('end',common.mustCall(()=>{
+constbody=Buffer.concat(chunks).toString();
+assert.strictEqual(body,'\nhello world\n');
+}));
+}
+
 asyncfunctiontestHttpGet(){
 consturl=`http://127.0.0.1:${httpServer.address().port}/hello-world`;
 constrequestWillBeSentFuture=once(session,'Network.requestWillBeSent')
@@ -146,18 +167,20 @@ async function testHttpGet() {
 port: httpServer.address().port,
 path: '/hello-world',
 headers: requestHeaders
-},common.mustCall((res)=>{
-// Dump the response.
-res.on('data',()=>{});
-res.on('end',()=>{});
-}));
+},common.mustCall(verifyHttpResponse));
 
 awaitrequestWillBeSentFuture;
 constresponseReceived=awaitresponseReceivedFuture;
 constloadingFinished=awaitloadingFinishedFuture;
 
 constdelta=(loadingFinished.timestamp-responseReceived.timestamp)*1000;
 assert.ok(delta>kDelta);
+
+constresponseBody=awaitsession.post('Network.getResponseBody',{
+requestId: responseReceived.requestId,
+});
+assert.strictEqual(responseBody.base64Encoded,false);
+assert.strictEqual(responseBody.body,'\nhello world\n');
 }
 
 asyncfunctiontestHttpsGet(){
@@ -177,18 +200,20 @@ async function testHttpsGet() {
 path: '/hello-world',
 rejectUnauthorized: false,
 headers: requestHeaders,
-},common.mustCall((res)=>{
-// Dump the response.
-res.on('data',()=>{});
-res.on('end',()=>{});
-}));
+},common.mustCall(verifyHttpResponse));
 
 awaitrequestWillBeSentFuture;
 constresponseReceived=awaitresponseReceivedFuture;
 constloadingFinished=awaitloadingFinishedFuture;
 
 constdelta=(loadingFinished.timestamp-responseReceived.timestamp)*1000;
 assert.ok(delta>kDelta);
+
+constresponseBody=awaitsession.post('Network.getResponseBody',{
+requestId: responseReceived.requestId,
+});
+assert.strictEqual(responseBody.base64Encoded,false);
+assert.strictEqual(responseBody.body,'\nhello world\n');
 }
 
 asyncfunctiontestHttpError(){