src: fix undefined script name in error source

PR-URL: #56502
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: legendecas

src/node_errors.cc

@@ -135,8 +135,13 @@ static std::string GetErrorSource(Isolate* isolate,
 
 // Print (filename):(line number): (message).
  ScriptOrigin origin = message->GetScriptOrigin();
- node::Utf8Value filename(isolate, message->GetScriptResourceName());
-constchar* filename_string = *filename;
+ std::string filename_string;
+if (message->GetScriptResourceName()->IsUndefined()) {
+ filename_string = "<anonymous_script>";
+ } else {
+ node::Utf8Value filename(isolate, message->GetScriptResourceName());
+ filename_string = filename.ToString();
+ }
 int linenum = message->GetLineNumber(context).FromJust();
 
 int script_start = (linenum - origin.LineOffset()) == 1

test/fixtures/errors/throw_in_eval_anonymous.js

@@ -0,0 +1,9 @@
+'use strict';
+require('../../common');
+
+Error.stackTraceLimit=1;
+eval(`
+
+ throw new Error('error in anonymous script');
+
+`)

test/fixtures/errors/throw_in_eval_anonymous.snapshot

@@ -0,0 +1,8 @@
+<anonymous_script>:*
+ throw new Error('error in anonymous script');
+ ^
+
+Error: error in anonymous script
+ at eval (eval at <anonymous> (*throw_in_eval_anonymous.js:*:*), <anonymous>:*:*)
+
+Node.js *

test/fixtures/errors/throw_in_eval_named.js

@@ -0,0 +1,8 @@
+evalscript.js:*
+ throw new Error('error in named script');
+ ^
+
+Error: error in named script
+ at eval (evalscript.js:*:*)
+
+Node.js *

test/fixtures/errors/throw_in_eval_named.snapshot

@@ -60,6 +60,8 @@ describe('errors output', { concurrency: true }, () => {
 {name: 'errors/if-error-has-good-stack.js',transform: errTransform},
 {name: 'errors/throw_custom_error.js',transform: errTransform},
 {name: 'errors/throw_error_with_getter_throw.js',transform: errTransform},
+{name: 'errors/throw_in_eval_anonymous.js',transform: errTransform},
+{name: 'errors/throw_in_eval_named.js',transform: errTransform},
 {name: 'errors/throw_in_line_with_tabs.js',transform: errTransform},
 {name: 'errors/throw_non_error.js',transform: errTransform},
 {name: 'errors/throw_null.js',transform: errTransform},