esm: fix cache collision on JSON files using file: URL

PR-URL: #49887Fixes: #49724
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Author: aduh95

lib/internal/modules/esm/translators.js

@@ -11,6 +11,7 @@ const {
  SafeArrayIterator,
  SafeMap,
  SafeSet,
+ StringPrototypeIncludes,
  StringPrototypeReplaceAll,
  StringPrototypeSlice,
  StringPrototypeStartsWith,
@@ -443,9 +444,12 @@ translators.set('json', function jsonStrategy(url, source) {
 debug(`Loading JSONModule ${url}`);
 constpathname=StringPrototypeStartsWith(url,'file:') ?
 fileURLToPath(url) : null;
+constshouldCheckAndPopulateCJSModuleCache=
+// We want to involve the CJS loader cache only for `file:` URL with no search query and no hash.
+pathname&&!StringPrototypeIncludes(url,'?')&&!StringPrototypeIncludes(url,'#');
 letmodulePath;
 letmodule;
-if(pathname){
+if(shouldCheckAndPopulateCJSModuleCache){
 modulePath=isWindows ?
 StringPrototypeReplaceAll(pathname,'/','\\') : pathname;
 module=CJSModule._cache[modulePath];
@@ -457,7 +461,7 @@ translators.set('json', function jsonStrategy(url, source) {
 }
 }
 source=stringify(source);
-if(pathname){
+if(shouldCheckAndPopulateCJSModuleCache){
 // A require call could have been called on the same file during loading and
 // that resolves synchronously. To make sure we always return the identical
 // export, we have to check again if the module already exists or not.
@@ -484,7 +488,7 @@ translators.set('json', function jsonStrategy(url, source) {
 err.message=errPath(url)+': '+err.message;
 throwerr;
 }
-if(pathname){
+if(shouldCheckAndPopulateCJSModuleCache){
 CJSModule._cache[modulePath]=module;
 }
 cjsCache.set(url,module);

test/es-module/test-esm-json.mjs

@@ -2,7 +2,10 @@ import { spawnPromisified } from '../common/index.mjs';
 import*asfixturesfrom'../common/fixtures.mjs';
 importassertfrom'node:assert';
 import{execPath}from'node:process';
-import{describe,it}from'node:test';
+import{describe,it,test}from'node:test';
+
+import{mkdir,rm,writeFile}from'node:fs/promises';
+import*astmpdirfrom'../common/tmpdir.js';
 
 importsecretfrom'../fixtures/experimental.json'assert{type: 'json' };
 
@@ -21,4 +24,61 @@ describe('ESM: importing JSON', () => {
 assert.strictEqual(code,0);
 assert.strictEqual(signal,null);
 });
+
+test('should load different modules when the URL is different',async(t)=>{
+constroot=tmpdir.fileURL(`./test-esm-json-${Math.random()}/`);
+try{
+awaitmkdir(root,{recursive: true});
+
+awaitt.test('json',async()=>{
+leti=0;
+consturl=newURL('./foo.json',root);
+awaitwriteFile(url,JSON.stringify({id: i++}));
+constabsoluteURL=awaitimport(`${url}`,{
+assert: {type: 'json'},
+});
+awaitwriteFile(url,JSON.stringify({id: i++}));
+constqueryString=awaitimport(`${url}?a=2`,{
+assert: {type: 'json'},
+});
+awaitwriteFile(url,JSON.stringify({id: i++}));
+consthash=awaitimport(`${url}#a=2`,{
+assert: {type: 'json'},
+});
+awaitwriteFile(url,JSON.stringify({id: i++}));
+constqueryStringAndHash=awaitimport(`${url}?a=2#a=2`,{
+assert: {type: 'json'},
+});
+
+assert.notDeepStrictEqual(absoluteURL,queryString);
+assert.notDeepStrictEqual(absoluteURL,hash);
+assert.notDeepStrictEqual(queryString,hash);
+assert.notDeepStrictEqual(absoluteURL,queryStringAndHash);
+assert.notDeepStrictEqual(queryString,queryStringAndHash);
+assert.notDeepStrictEqual(hash,queryStringAndHash);
+});
+
+awaitt.test('js',async()=>{
+leti=0;
+consturl=newURL('./foo.mjs',root);
+awaitwriteFile(url,`export default ${JSON.stringify({id: i++})}\n`);
+constabsoluteURL=awaitimport(`${url}`);
+awaitwriteFile(url,`export default ${JSON.stringify({id: i++})}\n`);
+constqueryString=awaitimport(`${url}?a=1`);
+awaitwriteFile(url,`export default ${JSON.stringify({id: i++})}\n`);
+consthash=awaitimport(`${url}#a=1`);
+awaitwriteFile(url,`export default ${JSON.stringify({id: i++})}\n`);
+constqueryStringAndHash=awaitimport(`${url}?a=1#a=1`);
+
+assert.notDeepStrictEqual(absoluteURL,queryString);
+assert.notDeepStrictEqual(absoluteURL,hash);
+assert.notDeepStrictEqual(queryString,hash);
+assert.notDeepStrictEqual(absoluteURL,queryStringAndHash);
+assert.notDeepStrictEqual(queryString,queryStringAndHash);
+assert.notDeepStrictEqual(hash,queryStringAndHash);
+});
+}finally{
+awaitrm(root,{force: true,recursive: true});
+}
+});
 });

test/es-module/test-esm-virtual-json.mjs

@@ -0,0 +1,30 @@
+import'../common/index.mjs';
+import*asfixturesfrom'../common/fixtures.mjs';
+import{register}from'node:module';
+importassertfrom'node:assert';
+
+asyncfunctionresolve(referrer,context,next){
+constresult=awaitnext(referrer,context);
+consturl=newURL(result.url);
+url.searchParams.set('randomSeed',Math.random());
+result.url=url.href;
+returnresult;
+}
+
+functionload(url,context,next){
+if(context.importAssertions.type==='json'){
+return{
+shortCircuit: true,
+format: 'json',
+source: JSON.stringify({data: Math.random()}),
+};
+}
+returnnext(url,context);
+}
+
+register(`data:text/javascript,export ${encodeURIComponent(resolve)};export ${encodeURIComponent(load)}`);
+
+assert.notDeepStrictEqual(
+awaitimport(fixtures.fileURL('empty.json'),{assert: {type: 'json'}}),
+awaitimport(fixtures.fileURL('empty.json'),{assert: {type: 'json'}}),
+);