fs: fix error when writing buffers > INT32_MAX

This reverts c380ee6.
uv_fs_write returns an int, so it is not possible to ask
it to write more than INT32_MAX.
Instead, validate 'length' is an int32 in JS to avoid
the assertion failure.
PR-URL: #38546
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: zbjornson

lib/internal/fs/utils.js

@@ -624,6 +624,8 @@ const validateOffsetLengthWrite = hideStackFrames(
 if(length<0){
 thrownewERR_OUT_OF_RANGE('length','>= 0',length);
 }
+
+validateInt32(length,'length',0);
 }
 );
 

src/node_file.cc

@@ -1831,8 +1831,8 @@ static void WriteBuffer(const FunctionCallbackInfo<Value>& args) {
 CHECK_LE(static_cast<uint64_t>(off_64), buffer_length);
 constsize_t off = static_cast<size_t>(off_64);
 
-CHECK(IsSafeJsInt(args[3]));
-constsize_t len = static_cast<size_t>(args[3].As<Integer>()->Value());
+CHECK(args[3]->IsInt32());
+constsize_t len = static_cast<size_t>(args[3].As<Int32>()->Value());
 CHECK(Buffer::IsWithinBounds(off, len, buffer_length));
 CHECK_LE(len, buffer_length);
 CHECK_GE(off + len, off);

test/parallel/test-fs-write-buffer-large.js

@@ -0,0 +1,40 @@
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+constpath=require('path');
+constfs=require('fs');
+
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
+// fs.write with length > INT32_MAX
+
+common.skipIf32Bits();
+
+letbuf;
+try{
+buf=Buffer.allocUnsafe(0x7FFFFFFF+1);
+}catch(e){
+// If the exception is not due to memory confinement then rethrow it.
+if(e.message!=='Array buffer allocation failed')throw(e);
+common.skip('skipped due to memory requirements');
+}
+
+constfilename=path.join(tmpdir.path,'write9.txt');
+fs.open(filename,'w',0o644,common.mustSucceed((fd)=>{
+assert.throws(()=>{
+fs.write(fd,
+buf,
+0,
+0x7FFFFFFF+1,
+0,
+common.mustNotCall());
+},{
+code: 'ERR_OUT_OF_RANGE',
+name: 'RangeError',
+message: 'The value of "length" is out of range. '+
+'It must be >= 0 && <= 2147483647. Received 2147483648'
+});
+
+fs.closeSync(fd);
+}));