stream: expose stream symbols

This is required for streams interop with e.g.
readable-stream. Currently readable-stream helpers
will not work with normal node streams which is
confusing and bad for the ecosystem.
PR-URL: #45671
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>

Author: ronag

lib/internal/streams/destroy.js

@@ -11,7 +11,7 @@ const {
  Symbol,
 }=primordials;
 const{
-kDestroyed,
+kIsDestroyed,
  isDestroyed,
  isFinished,
  isServerRequest,
@@ -327,7 +327,7 @@ function destroyer(stream, err) {
 }
 
 if(!stream.destroyed){
-stream[kDestroyed]=true;
+stream[kIsDestroyed]=true;
 }
 }
 

lib/internal/streams/utils.js

@@ -1,16 +1,20 @@
 'use strict';
 
 const{
- Symbol,
  SymbolAsyncIterator,
  SymbolIterator,
  SymbolFor,
 }=primordials;
 
-constkDestroyed=Symbol('kDestroyed');
-constkIsErrored=Symbol('kIsErrored');
-constkIsReadable=Symbol('kIsReadable');
-constkIsDisturbed=Symbol('kIsDisturbed');
+// We need to use SymbolFor to make these globally available
+// for interopt with readable-stream, i.e. readable-stream
+// and node core needs to be able to read/write private state
+// from each other for proper interoperability.
+constkIsDestroyed=SymbolFor('nodejs.stream.destroyed');
+constkIsErrored=SymbolFor('nodejs.stream.errored');
+constkIsReadable=SymbolFor('nodejs.stream.readable');
+constkIsWritable=SymbolFor('nodejs.stream.writable');
+constkIsDisturbed=SymbolFor('nodejs.stream.disturbed');
 
 constkIsClosedPromise=SymbolFor('nodejs.webstream.isClosedPromise');
 constkControllerErrorFunction=SymbolFor('nodejs.webstream.controllerErrorFunction');
@@ -104,7 +108,7 @@ function isDestroyed(stream) {
 constwState=stream._writableState;
 constrState=stream._readableState;
 conststate=wState||rState;
-return!!(stream.destroyed||stream[kDestroyed]||state?.destroyed);
+return!!(stream.destroyed||stream[kIsDestroyed]||state?.destroyed);
 }
 
 // Have been end():d.
@@ -162,6 +166,7 @@ function isReadable(stream) {
 }
 
 functionisWritable(stream){
+if(stream&&stream[kIsWritable]!=null)returnstream[kIsWritable];
 if(typeofstream?.writable!=='boolean')returnnull;
 if(isDestroyed(stream))returnfalse;
 returnisWritableNodeStream(stream)&&
@@ -298,7 +303,8 @@ function isErrored(stream) {
 }
 
 module.exports={
- kDestroyed,
+ isDestroyed,
+ kIsDestroyed,
  isDisturbed,
  kIsDisturbed,
  isErrored,
@@ -307,8 +313,8 @@ module.exports = {
  kIsReadable,
  kIsClosedPromise,
  kControllerErrorFunction,
+ kIsWritable,
  isClosed,
- isDestroyed,
  isDuplexNodeStream,
  isFinished,
  isIterable,

lib/stream.js

@@ -51,9 +51,13 @@ const promises = require('stream/promises');
 constutils=require('internal/streams/utils');
 
 constStream=module.exports=require('internal/streams/legacy').Stream;
+
+Stream.isDestroyed=utils.isDestroyed;
 Stream.isDisturbed=utils.isDisturbed;
 Stream.isErrored=utils.isErrored;
 Stream.isReadable=utils.isReadable;
+Stream.isWritable=utils.isWritable;
+
 Stream.Readable=require('internal/streams/readable');
 for(constkeyofObjectKeys(streamReturningOperators)){
 constop=streamReturningOperators[key];