perf_hooks: do not return all entries with getEntriesBy[Name|Type]

Fix: #42028
PR-URL: #42104Fixes: #42028
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: meixg

lib/internal/perf/performance.js

@@ -9,6 +9,7 @@ const {
 const{
 codes: {
 ERR_ILLEGAL_CONSTRUCTOR,
+ERR_MISSING_ARGS
 }
 }=require('internal/errors');
 
@@ -86,16 +87,18 @@ function getEntries() {
 }
 
 functiongetEntriesByName(name){
-if(name!==undefined){
-name=`${name}`;
+if(arguments.length===0){
+thrownewERR_MISSING_ARGS('name');
 }
+name=`${name}`;
 returnfilterBufferMapByNameAndType(name,undefined);
 }
 
 functiongetEntriesByType(type){
-if(type!==undefined){
-type=`${type}`;
+if(arguments.length===0){
+thrownewERR_MISSING_ARGS('type');
 }
+type=`${type}`;
 returnfilterBufferMapByNameAndType(undefined,type);
 }
 

test/parallel/test-performance-timeline.mjs

@@ -33,3 +33,18 @@ await setTimeout(50);
 performance.measure('a','one');
 constentriesByName=performance.getEntriesByName('a');
 assert.deepStrictEqual(entriesByName.map((x)=>x.entryType),['measure','mark','measure','mark']);
+
+// getEntriesBy[Name|Type](undefined)
+performance.mark(undefined);
+assert.strictEqual(performance.getEntriesByName(undefined).length,1);
+assert.strictEqual(performance.getEntriesByType(undefined).length,0);
+assert.throws(()=>performance.getEntriesByName(),{
+name: 'TypeError',
+message: 'The "name" argument must be specified',
+code: 'ERR_MISSING_ARGS'
+});
+assert.throws(()=>performance.getEntriesByType(),{
+name: 'TypeError',
+message: 'The "type" argument must be specified',
+code: 'ERR_MISSING_ARGS'
+});