src: make parameter name const reference in method TriggerNodeReport

gengjiawen · BridgeAR · commit c7bd21cfff0f · 2019-03-14T11:02:29.000+01:00
PR-URL: #26397 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -99,7 +99,7 @@ std::string TriggerNodeReport(Isolate* isolate,
 Environment* env,
 const char* message,
 const char* trigger,
- std::string name,
+ const std::string& name,
 Local<String> stackstr) {
 std::ostringstream oss;
 std::string filename;
diff --git a/src/node_report.h b/src/node_report.h
@@ -44,7 +44,7 @@ std::string TriggerNodeReport(v8::Isolate* isolate,
 node::Environment* env,
 const char* message,
 const char* trigger,
- std::string name,
+ const std::string& name,
 v8::Local<v8::String> stackstr);
 void GetNodeReport(v8::Isolate* isolate,
 node::Environment* env,

-Original file line number
+Diff line change
  node::Environment* env,
 constchar* message,
 constchar* trigger,
 - std::string name,
 +conststd::string& name,
  v8::Local<v8::String> stackstr);
 voidGetNodeReport(v8::Isolate* isolate,
  node::Environment* env,